update app, middleware and 05-port modules with ChanUpgradeTimeout function

[charleenfei]

Description

part of the work needed for #3855

note that this PR does not actually implement the functionality of the app callbacks, it only sets up the blocker

---

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

• Targeted PR against correct branch (see CONTRIBUTING.md).
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards and Go style guide.
• Wrote unit and integration tests.
• Updated relevant documentation (docs/) or specification (x/<module>/spec/).
• Added relevant godoc comments.
• Provide a commit message to be used for the changelog entry in the PR description for review.
• Re-reviewed Files changed in the Github PR explorer.
• Review Codecov Report in the comment section below once CI passes.

[DimitrisJim]

any reason why you forward here instead of nil? Just curious.

[charleenfei]

ah, because we are calling it from the controller middleware here which should pass the call through to the app for the app callback.

basically, this would be called in the usecase where you have an underlying module that you want to use to authenticate ICA actions (the kinda v0 auth module design we had for ICA), and then you wrap that application with the ICA controller middleware. in the v1 design you can pass a nil app to the ICA controller middleware, and use the controller msg_server directly.

[chatton]

LGTM!

[DimitrisJim]

Looks good to me 🚀

[colin-axner]

Can you link me to the discussion for adding OnChanUpgradeTimeout? I see the spec uses OnChanUpgradeRestore and I'm curious what use cases there are for apps distinguishing between cancelled upgrades and upgrades which were timed out

[charleenfei]

yea, it's here: https://github.com/cosmos/ibc/blob/main/spec/core/ics-004-channel-and-packet-semantics/UPGRADES.md#timeout-upgrade-process

[colin-axner]

Where do you see OnChanUpgradeTimeout?

I see:

  // restore callback must not return error since counterparty successfully restored previous channelEnd
    module.onChanUpgradeRestore(
        portIdentifer,
        channelIdentifier
    )
}

[charleenfei]

ahhhh i think youre absolutely right 🙈

[charleenfei]

will correct in a followup pr!

[colin-axner]

Sounds good, no worries. Just made sense to me to only have 1 app callback for channel upgrade failure scenarios