Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e libc complaints #3851

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Fix e2e libc complaints #3851

merged 1 commit into from
Jun 15, 2023

Conversation

DimitrisJim
Copy link
Contributor

@DimitrisJim DimitrisJim commented Jun 14, 2023

Description

Never has a change so tiny caused such a headache. Bumping go to use golang:1.20 apparently caused simd to be compiled with a dependency on libc that had to be >= 2.32, hence the error logs for all e2e runs. Pretty sure the PR for bumping this didn't blow up because it was from a forked repo (running e2e from forks works okay since simd is built from the workflow and uses ubuntu 22.04 itself)

Bumping the Dockerfile image to 22.04 solves the issue since it seems it comes with a newer version of libc. Alternatively, I'm sure an apt-get would also do the trick.

Note, might be worth it to check that the simd binary is runnable after being built in the dockerfile.

closes: #XXXX

Commit Message / Changelog Entry

chore: bump image used for simd to 22.04

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DimitrisJim. ❤️‍🔥 And sorry for all the headache this caused you. 🤒

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for figuring this one out <3

@crodriguezvega crodriguezvega merged commit 540d64b into main Jun 15, 2023
1 check passed
@crodriguezvega crodriguezvega deleted the attempt_libc_mismatch branch June 15, 2023 10:06
@colin-axner
Copy link
Contributor

Thank you @DimitrisJim! ❤️

mergify bot pushed a commit that referenced this pull request Jun 22, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
crodriguezvega pushed a commit that referenced this pull request Jun 22, 2023
…should match the one by github runners. (#3851) (#3943)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
@faddat faddat mentioned this pull request Jun 23, 2023
9 tasks
mergify bot pushed a commit that referenced this pull request Jul 14, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
damiannolan pushed a commit that referenced this pull request Jul 14, 2023
…should match the one by github runners. (#3851) (#4084)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
mergify bot pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851)

(cherry picked from commit 540d64b)
chatton pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851) (#4699)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
chatton pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851) (#4700)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
chatton pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851) (#4701)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
chatton pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851) (#4704)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
chatton pushed a commit that referenced this pull request Sep 18, 2023
…should match the one by github runners. (#3851) (#4702)

(cherry picked from commit 540d64b)

Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants