-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding msg server implementation for ChannelUpgradeAck
#3849
Merged
damiannolan
merged 32 commits into
04-channel-upgrades
from
damian/3742-upgrade-ack-msg-server
Jun 21, 2023
Merged
Changes from 22 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1293330
adding boilerplate skeleton for chanUpgradeAck handler
damiannolan c4dce22
Merge branch '04-channel-upgrades' into damian/1620-chan-upgrade-ack
damiannolan a8c6882
updating msg servers args
damiannolan c17c8ed
adding test scaffolding and syncing latest changes of feat branch
damiannolan 152a873
Merge branch '04-channel-upgrades' into damian/1620-chan-upgrade-ack
damiannolan fbacd83
configure both proposed upgrades to use mock.UpgradeVersion
damiannolan dfaf589
Merge branch '04-channel-upgrades' into damian/1620-chan-upgrade-ack
damiannolan 2834124
Merge branch '04-channel-upgrades' into damian/1620-chan-upgrade-ack
damiannolan f92edcb
updating chanUpgradeAck test cases
damiannolan 0ae120f
updating var naming for consistency, adding additional testcases
damiannolan 73e9352
rm msg server implementation
damiannolan 2b8b3fe
adding invalid flush status err and rm lint ignore comment
damiannolan e53d1aa
adding test helpers to endpoint for get/set channel upgrade
damiannolan f9c2167
lint it
damiannolan 566ab66
adding initial msg server impl skeleton
damiannolan c241a63
pull in code for WriteUpgradeAckChannel
damiannolan b1958fd
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan ec60447
adding result to MsgChannelUpgradeAckResponse
damiannolan b82afaf
Merge branch 'damian/update-ack-response-args' into damian/3742-upgra…
damiannolan 7082cd8
add initial test cases
damiannolan 80326a0
adding additional testcases
damiannolan c870ce1
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan cd3d443
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan d23c6f1
apply testcase naming review suggestions
damiannolan 4ba1751
apply error return wrapping suggestions from review
damiannolan a710ee4
fix error to use Wrapf and correct channel id arg, adding success log
damiannolan e75f1ca
correct testing imports and satisy linter
damiannolan 0169d98
apply self suggestions for testcase context with in-line comments
damiannolan 9d71ee5
updating test func to use path.EndpointA and chainA sender acc
damiannolan 970d006
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan d60bf1f
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan 215280c
Merge branch '04-channel-upgrades' into damian/3742-upgrade-ack-msg-s…
damiannolan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was cut and paste from a merge conflict, whoops -_-
wanted to fix ordering of funcs