Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a scheduled run for hermes. #3822

Merged
merged 3 commits into from
Jun 14, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,14 @@
# The Tests / E2E workflow is used to run end-to-end tests on pull requests originating
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes more sense to add the change to run hermes here instead of duplicating all of the workflow

# from the ibc-go repository. The workflow is triggered on a PR opening, when new commits
# are pushed to the PR, or when the PR is marked ready for review.
#
# A scheduled job is also set up to run every night. This job is used to run e2e tests
# using the hermes relayer.
name: Tests / E2E
on:
# This schedule is used solely for hermes and is set to run every night.
schedule:
- cron: "0 0 * * *"
workflow_dispatch:
pull_request:
types:
Expand Down Expand Up @@ -37,7 +46,16 @@ jobs:
echo "Using tag $tag"
echo "simd-tag=$tag" >> $GITHUB_OUTPUT
fi

# get-relayer will return either hermes or rly depending on whether the workflow was triggered
# by a scheduled run or not.
- id: get-relayer
run: |
if [ "${{ github.event_name }}" == "schedule" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the event is schedule we set hermes as the relayer, if not rly is set.

then
echo "relayer=hermes" >> $GITHUB_OUTPUT
else
echo "relayer=rly" >> $GITHUB_OUTPUT
fi
# build-e2e ensures that all test code compiles.
build-e2e:
if: ${{ !github.event.pull_request.draft && !github.event.pull_request.head.repo.fork && github.actor != 'dependabot[bot]' }}
Expand Down Expand Up @@ -80,3 +98,4 @@ jobs:
chain-binary: 'simd'
# on regular PRs we won't run interchain account or upgrade tests.
test-exclusions: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite'
relayer-tag: "${{ needs.determine-image-tag.outputs.relayer }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass as input to the workflow.