-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WriteUpgradeTimeout #3797
Merged
charleenfei
merged 21 commits into
04-channel-upgrades
from
charly/#37500-write-upgrade-timeout
Jun 16, 2023
Merged
WriteUpgradeTimeout #3797
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
50b1163
writeupgradetimeout method, pull in util methods
charleenfei ba1fde4
update method to use abort method instead of restoreChannel
charleenfei 8cd8c0b
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei c3fc032
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 4e5d866
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 940646d
add errors
charleenfei 6063131
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 8695fb2
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 126c833
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 7556af7
Merge branch 'charly/#37500-write-upgrade-timeout' of github.com:cosm…
charleenfei 178b2d3
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei e2d367a
pr comments
charleenfei af566f7
return value
charleenfei e6d089d
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 8473fca
update response with getter
charleenfei 0199a14
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei 324fac8
Merge branch 'charly/#37500-write-upgrade-timeout' of github.com:cosm…
charleenfei 715ef16
pr comments
charleenfei 0107b53
proto back to original
charleenfei d16acce
tx.pb
charleenfei 5f2a911
Merge branch '04-channel-upgrades' into charly/#37500-write-upgrade-t…
charleenfei File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
AbortUpgrade
function writes an error receipt to state for counterparty upgrade cancellation but in this scenario the counterparty is in its original state and we are just wanting to restore our channel end to its original state also.Its only possible to timeout an upgrade handshake if the counterparty stalls on TRY (remaining in an open state) and we have committed the INIT step which we need to revert/timeout. So writing the error receipt here is redundant.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmos/ibc#986
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Timeouts can also occur if an insufficient timeout was set during INIT