change error text of total escrow migration #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crodriguezvega
requested review from
colin-axner,
AdityaSripal and
damiannolan
as code owners
crodriguezvega
commented
Jun 7, 2023
| @@ -109,7 +109,7 @@ func (am AppModule) RegisterServices(cfg module.Configurator) { | |||
| } | |||
|
|
|||
| if err := cfg.RegisterMigration(types.ModuleName, 2, m.MigrateTotalEscrowForDenom); err != nil { | |||
| panic(fmt.Sprintf("failed to migrate total escrow amount from version 2 to 3: %v", err)) | |||
| panic(fmt.Sprintf("failed to migrate transfer app from version 2 to 3: %v", err)) | |||
| } | |||
|
|
|||
| if err := cfg.RegisterMigration(types.ModuleName, 3, m.MigrateParams); err != nil { | |||
There was a problem hiding this comment.
I will update also the error text for this one in a separate PR. Didn't do it here to make backport easier.
There was a problem hiding this comment.
doesn't it make more sense to be specific about which migration failed? Or is this indicated someplace else?
damiannolan
approved these changes
Jun 7, 2023
colin-axner
approved these changes
Jun 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3775 +/- ##
=======================================
Coverage 78.75% 78.75%
=======================================
Files 187 187
Lines 12890 12890
=======================================
Hits 10151 10151
Misses 2308 2308
Partials 431 431
|
crodriguezvega
deleted the
carlos/update-error-message-total-escrow-migration
branch
mergify bot
pushed a commit
that referenced
this pull request
Jun 7, 2023
(cherry picked from commit d7d9fa9)
crodriguezvega
added a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small one... Just noticed that error message did not follow the convention.
closes: #XXXX
Commit Message / Changelog Entry
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.