Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: add function field to override SendMsgs #3767

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jun 6, 2023

Description

closes: #3123

Commit Message / Changelog Entry

testing: add function field to override SendMsgs

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

…-to-instead-be-an-interface-or-passed-in-function
Copy link
Contributor

@DimitrisJim DimitrisJim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@charleenfei charleenfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

DimitrisJim and others added 2 commits June 7, 2023 15:48
…-to-instead-be-an-interface-or-passed-in-function
…-to-instead-be-an-interface-or-passed-in-function
…-to-instead-be-an-interface-or-passed-in-function
@crodriguezvega crodriguezvega merged commit 0063319 into main Jun 10, 2023
1 check passed
@crodriguezvega crodriguezvega deleted the carlos/3123-push-chainsendmsgs-in-ibctesting-to-instead-be-an-interface-or-passed-in-function branch June 10, 2023 14:57
@colin-axner
Copy link
Contributor

colin-axner commented Aug 24, 2023

Adding backport so we can use to fix testing conflicts on the callbacks module, also is a useful feature to backport

mergify bot pushed a commit that referenced this pull request Aug 24, 2023
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
(cherry picked from commit 0063319)
colin-axner pushed a commit that referenced this pull request Aug 24, 2023
Co-authored-by: Jim Fasarakis-Hilliard <d.f.hilliard@gmail.com>
(cherry picked from commit 0063319)

Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push Chain.SendMsgs in ibctesting to instead be an interface or passed in function
6 participants