chore: update send packet api #3573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…go into charly/timeout_util_function
9 tasks
damiannolan
reviewed
May 15, 2023
Comment on lines
137
to
168
| // NewTimeout creates a new Timeout instance. | ||
| func NewTimeout(height clienttypes.Height, timestamp uint64) Timeout { | ||
| return Timeout{ | ||
| Height: height, | ||
| Timestamp: timestamp, | ||
| } | ||
| } | ||
|
|
||
| // AfterHeight returns true if Timeout height is greater than the provided height. | ||
| func (t Timeout) AfterHeight(height clienttypes.Height) bool { | ||
| return t.Height.GT(height) | ||
| } | ||
|
|
||
| // AfterTimestamp returns true is Timeout timestamp is greater than the provided timestamp. | ||
| func (t Timeout) AfterTimestamp(timestamp uint64) bool { | ||
| return t.Timestamp > timestamp | ||
| } | ||
|
|
||
| // IsValid validates the Timeout. It ensures that either height or timestamp is set. | ||
| func (t Timeout) IsValid() bool { | ||
| return !t.ZeroHeight() || !t.ZeroTimestamp() | ||
| } | ||
|
|
||
| // ZeroHeight returns true if Timeout height is zero, otherwise false. | ||
| func (t Timeout) ZeroHeight() bool { | ||
| return t.Height.IsZero() | ||
| } | ||
|
|
||
| // ZeroTimestamp returns true if Timeout timestamp is zero, otherwise false. | ||
| func (t Timeout) ZeroTimestamp() bool { | ||
| return t.Timestamp == 0 | ||
| } |
There was a problem hiding this comment.
Would be nice to add a timeout.go file maybe, as Timeout will be used for both packets and upgrades
DimitrisJim
reviewed
May 15, 2023
| @@ -431,7 +431,8 @@ func (endpoint *Endpoint) SendPacket( | |||
| channelCap := endpoint.Chain.GetChannelCapability(endpoint.ChannelConfig.PortID, endpoint.ChannelID) | |||
There was a problem hiding this comment.
Adding here now so I don't forget about it: there's also SendPacket in endpoint.go which might need to be updated to match SendPacket in packet.go.
|
closing in favour of #3732 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this pr updates the SendPacket API to use the new Timeout struct
closes: #3551
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.