-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: changes for ics #3496
feat: changes for ics #3496
Conversation
Thanks, @faddat. Could you please give us some more context/information of why this change would be needed? If I look at cosmos/interchain-security#817 and I see the item |
I cannot, sorry. @vuong177 can. This needs to be linked to this: cosmos/interchain-security#852 and |
hey yeah it weird please see the code lines in the link https://github.com/cosmos/interchain-security/blob/main/app/consumer/app.go#L317-L342. So we need the |
@crodriguezvega would this be better if it targeted main? Also do you happen to see another way around it? thank you. |
@sontrinh16 I am going to make a pr that targets main, I think that the ibc-go team is preparing v8.0.0 right now. I'll also leave this one open. @crodriguezvega thanks very much for your review. |
Thanks for the explanations and the extra context, @sontrinh16 and @faddat. I see in the interchain-security repo that an alternative approach is being followed for the upgrade to SDK 0.47 and ibc-go v7. Does that mean that we could close this PR? |
yes i think we can close this one |
Thank you for the quick reply, @sontrinh16! |
Description
This PR is part of an effort to support sdk 47 and ibc7 without forks. We
would love review and feedback, but it shouldn't be considered for merging
at this time.
It relates to this PR on ICS:
cosmos/interchain-security#817
Commit Message / Changelog Entry
pending. We don't even know if this should be merged, and the pr is being
made so that we can get advice.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
).godoc
comments.Files changed
in the Github PR explorer.Codecov Report
in the comment section below once CI passes.