Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nit: Use sdk blocks instead of tendermint blocks. #3440

Merged
merged 9 commits into from
May 3, 2023

Conversation

DimitrisJim
Copy link
Contributor

Description

Reference: cosmos/cosmos-sdk#3544

basically saw it since its the only thing my editor is currently complaining about

Commit Message / Changelog Entry

nit: Use sdk blocks instead of tendermint blocks.

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed the comment about why we chose to use res.Block instead of res.SdkBlock. I think we will need to double check the versions we support and when we can actually make this change.

e2e/testsuite/grpc_query.go Outdated Show resolved Hide resolved
@DimitrisJim DimitrisJim marked this pull request as draft April 12, 2023 12:58
@DimitrisJim DimitrisJim marked this pull request as ready for review April 18, 2023 08:58
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I won't leave an approval as I now have some commits here, but I think this new interface type should do the trick!

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

e2e/testsuite/grpc_query.go Outdated Show resolved Hide resolved
@colin-axner colin-axner dismissed chatton’s stale review May 3, 2023 14:22

requested changes applied

@DimitrisJim DimitrisJim merged commit cc09f72 into main May 3, 2023
@DimitrisJim DimitrisJim deleted the jim/grpc_block_warning branch May 3, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants