Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Channel Upgrade Try functionality for 04 channel #3333

Closed
wants to merge 83 commits into from
Closed

Implement Channel Upgrade Try functionality for 04 channel #3333

wants to merge 83 commits into from

Commits on Mar 20, 2023

  1. WIP - adding scaffolding for channel upgrade init

    @damiannolan
    damiannolan committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    50e84bc View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. adding application callbacks and no-op implementations

    @chatton
    chatton committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    72d2c75 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'cian/damian/add-noop-application-callbacks' into damian… 

    …/1618-chan-upgrade-init
    @damiannolan
    damiannolan committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    cef2f6b View commit details
    Browse the repository at this point in the history

  3. refactoring init upgrade handler and adding tests

    @damiannolan
    damiannolan committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    ca6bc94 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. adding additional testing, response values and events

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    c3bc3ae View commit details
    Browse the repository at this point in the history

  2. adding rough impl of subset of ordering method

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    43eeaab View commit details
    Browse the repository at this point in the history

  3. adding additional test for upgrade ordering

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    86753be View commit details
    Browse the repository at this point in the history

  4. Merge branch '04-channel-upgrades' into damian/1618-chan-upgrade-init

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    95b6a2c View commit details
    Browse the repository at this point in the history

  5. adding godocs

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    21dfc70 View commit details
    Browse the repository at this point in the history

  6. updating testing endpoint func to accept timeout args

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    524ec5e View commit details
    Browse the repository at this point in the history

  7. satisfy the linter... waaaahh

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    f1f8e69 View commit details
    Browse the repository at this point in the history

  8. cap -> chanCap

    @damiannolan
    damiannolan committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    012d768 View commit details
    Browse the repository at this point in the history

  9. test: adding test for VerifyUpgradeSequenceRecv

    @chatton
    chatton committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    186c279 View commit details
    Browse the repository at this point in the history

  10. rename test function

    @chatton
    chatton committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a823c2f View commit details
    Browse the repository at this point in the history

  11. Update modules/core/03-connection/keeper/verify.go 

    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    @chatton @damiannolan
    chatton and damiannolan authored Mar 23, 2023
    Configuration menu
    Copy the full SHA
    16ced5b View commit details
    Browse the repository at this point in the history

  12. wip: added most of ChannelUpgradeTry

    @chatton
    chatton committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    bde47ac View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. adding generic contains method

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    ac962e1 View commit details
    Browse the repository at this point in the history

  2. adding upgrade seq to events and response, move version check to vali… 

    …datebasic, pull in subset ordering suggestions and adding tests
    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    39fead1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'damian/1618-chan-upgrade-init' into cian/issue#1608-add… 

    …-verifychannelupgradesequence-method-to-03-connection
    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    add66ad View commit details
    Browse the repository at this point in the history

  4. Merge branch 'cian/issue#1608-add-verifychannelupgradesequence-method… 

    …-to-03-connection' into cian/issue#1619-implement-channelupgradetry-functionality-for-04-channel
    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    903396f View commit details
    Browse the repository at this point in the history

  5. adding getter/setter for ErrorReceipt, adding tests

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    032551f View commit details
    Browse the repository at this point in the history

  6. adding testing scaffolding for chan upgrade try

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0c6cbfb View commit details
    Browse the repository at this point in the history

  7. adding more test coverage

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    6287f1b View commit details
    Browse the repository at this point in the history

  8. use proposed upgrade channel connection, adding test case

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    165e23d View commit details
    Browse the repository at this point in the history

  9. move empty version checking of proposed channel upgrade to validate b… 

    …asic
    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    f34298d View commit details
    Browse the repository at this point in the history

  10. fix port and channel ids passed to verify funcs

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    9ecf67b View commit details
    Browse the repository at this point in the history

  11. use counterparty ids from upgrade channel

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5dc87f1 View commit details
    Browse the repository at this point in the history

  12. adding upgrade sequence return value, inline comments and some refactor

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    474a7d8 View commit details
    Browse the repository at this point in the history

  13. adding restore channel scaffolding

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e56607f View commit details
    Browse the repository at this point in the history

  14. adding write func for successful upgrade try

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    30d076c View commit details
    Browse the repository at this point in the history

  15. discard redundant proofHeights in test endpoint

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    18e81a8 View commit details
    Browse the repository at this point in the history

  16. commit error receipt to state and abort channel upgrade early

    @damiannolan
    damiannolan committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1696a70 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. ensure upgraded channel connection end is relative to counterparty

    @damiannolan
    damiannolan committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    4c51388 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. merge with feature branch and add calls to verifiy and restore functions

    @chatton
    chatton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e797812 View commit details
    Browse the repository at this point in the history

  2. updated error message

    @chatton
    chatton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    e5fd5d6 View commit details
    Browse the repository at this point in the history

  3. added previous version as return argument

    @chatton
    chatton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    eed9b91 View commit details
    Browse the repository at this point in the history

  4. re-added tests for UpgradeTry

    @chatton
    chatton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    f1b19ba View commit details
    Browse the repository at this point in the history

  5. wip: adding test for crossing hellos

    @chatton
    chatton committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    c5cf6e6 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. refactor chan upgrade try to accomodate crossing hellos, adding test … 

    …cases
    @damiannolan
    damiannolan committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    9b750c1 View commit details
    Browse the repository at this point in the history

  2. adding additional test cases for connection not found, invalid counte… 

    …rparty connection
    @damiannolan
    damiannolan committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    1dde2ea View commit details
    Browse the repository at this point in the history

  3. adding more tests and timeout checks commented out

    @damiannolan
    damiannolan committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    3f4205e View commit details
    Browse the repository at this point in the history

  4. cleanup

    @damiannolan
    damiannolan committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    fcc0c34 View commit details
    Browse the repository at this point in the history

  5. appeased the linting overlords

    @chatton
    chatton committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    0de9d39 View commit details
    Browse the repository at this point in the history

  6. adding timeout tests

    @chatton
    chatton committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    564ddec View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. cleaning up some testcases

    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    3124a14 View commit details
    Browse the repository at this point in the history

  2. adding happy path response values

    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    ba9b2c4 View commit details
    Browse the repository at this point in the history

  3. adding upgrade try events

    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    ccced69 View commit details
    Browse the repository at this point in the history

  4. cleanup errors file

    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    438ea63 View commit details
    Browse the repository at this point in the history

  5. Merge branch '04-channel-upgrades' into cian/issue#1619-implement-cha… 

    …nnelupgradetry-functionality-for-04-channel
    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    7f7c399 View commit details
    Browse the repository at this point in the history

  6. removing check that is already in validate basic

    @damiannolan
    damiannolan committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    ddf179d View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2023

  1. merge 04-channel-upgrades

    @chatton
    chatton committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    900e632 View commit details
    Browse the repository at this point in the history

  2. update with spec changes

    @charleenfei
    charleenfei committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8ddc924 View commit details
    Browse the repository at this point in the history

  3. update upgrade sequence code blockk

    @charleenfei
    charleenfei committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    0d49837 View commit details
    Browse the repository at this point in the history

  4. created separate function to return the connection end

    @chatton
    chatton committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    8fcca78 View commit details
    Browse the repository at this point in the history

  5. update missing test coverage

    @charleenfei
    charleenfei committed Apr 3, 2023
    Configuration menu
    Copy the full SHA
    1886a50 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2023

  1. fix linting issues

    @chatton
    chatton committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    ea1d7dc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'separate-out-happypath-crossing-hellos' into cian/issue… 

    …#1619-implement-channelupgradetry-functionality-for-04-channel
    @chatton
    chatton committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    9352b30 View commit details
    Browse the repository at this point in the history

  3. adding additional test cases and assigning fields to existing channel

    @chatton
    chatton committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    e389c77 View commit details
    Browse the repository at this point in the history

  4. added check to verify the computed upgrade channel equals the expecte… 

    …d one
    @chatton
    chatton committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    4839088 View commit details
    Browse the repository at this point in the history

  5. todos

    @charleenfei
    charleenfei committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    05a299f View commit details
    Browse the repository at this point in the history

  6. mv event emission to other pr

    @charleenfei
    charleenfei committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    4eea882 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. fix linter

    @chatton
    chatton committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    004162b View commit details
    Browse the repository at this point in the history

  2. small error message change

    @crodriguezvega
    crodriguezvega authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    7df0e52 View commit details
    Browse the repository at this point in the history

  3. remove callback word from log messages

    @crodriguezvega
    crodriguezvega authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    35c7e35 View commit details
    Browse the repository at this point in the history

  4. add log message on failed upgrade try callback

    @crodriguezvega
    crodriguezvega authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    64ef5aa View commit details
    Browse the repository at this point in the history

  5. addressing PR feedback

    @chatton
    chatton committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    abe38fe View commit details
    Browse the repository at this point in the history

  6. Merge branch '04-channel-upgrades' into cian/issue#1619-implement-cha… 

    …nnelupgradetry-functionality-for-04-channel
    @chatton
    chatton authored Apr 5, 2023
    Configuration menu
    Copy the full SHA
    01b883f View commit details
    Browse the repository at this point in the history

  7. rm deep equal check in favour of zeroing custom fields

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    bc145f9 View commit details
    Browse the repository at this point in the history

  8. update test coverage to test for channel state

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    dab7eb1 View commit details
    Browse the repository at this point in the history

  9. lint

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    163cd9a View commit details
    Browse the repository at this point in the history

  10. pr review updates

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    6547783 View commit details
    Browse the repository at this point in the history

  11. precommit

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    f445158 View commit details
    Browse the repository at this point in the history

  12. rm references to chanCap

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    5874333 View commit details
    Browse the repository at this point in the history

  13. update

    @charleenfei
    charleenfei committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    00a3136 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. addressing PR feedback

    @chatton
    chatton committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    c158a98 View commit details
    Browse the repository at this point in the history

  2. remove restore call from timeout checks

    @chatton
    chatton committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    d6660b0 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2023

  1. Merge branch '04-channel-upgrades' into channel-upgrade-try

    @charleenfei
    charleenfei committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    b79cdfc View commit details
    Browse the repository at this point in the history

  2. Merge branch 'cian/issue#1619-implement-channelupgradetry-functionali… 

    …ty-for-04-channel' of github.com:cosmos/ibc-go into channel-upgrade-try
    @charleenfei
    charleenfei committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    946d3c5 View commit details
    Browse the repository at this point in the history

  3. merge conflicts

    @charleenfei
    charleenfei committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    61427c0 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'cian/issue#1619-implement-channelupgradetry-functionali… 

    …ty-for-04-channel' of https://github.com/cosmos/ibc-go into cian/issue#1619-implement-channelupgradetry-functionality-for-04-channel
    @chatton
    chatton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    bd8574c View commit details
    Browse the repository at this point in the history

  5. Merge branch '04-channel-upgrades' into cian/issue#1619-implement-cha… 

    …nnelupgradetry-functionality-for-04-channel
    @chatton
    chatton authored Apr 11, 2023
    Configuration menu
    Copy the full SHA
    f9d0ee6 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'cian/issue#1619-implement-channelupgradetry-functionali… 

    …ty-for-04-channel' of https://github.com/cosmos/ibc-go into cian/issue#1619-implement-channelupgradetry-functionality-for-04-channel
    @chatton
    chatton committed Apr 11, 2023
    Configuration menu
    Copy the full SHA
    a3603f8 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. fixing tests for init and try

    @chatton
    chatton committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    77848dd View commit details
    Browse the repository at this point in the history