Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ics29 packet callbacks #331

Closed
wants to merge 20 commits into from
Closed

feat: ics29 packet callbacks #331

wants to merge 20 commits into from

Conversation

charleenfei
Copy link
Contributor

Description

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

dependabot bot and others added 17 commits July 20, 2021 13:15
@dependabot @colin-axner
Bump codecov/codecov-action from 1.5.2 to 2.0.1 (#273)
c623ad7 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 1.5.2 to 2.0.1.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v1.5.2...v2.0.1)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@colin-axner @AdityaSripal
remove ChanCloseInit function from transfer keeper (#275)
0afa15a 
* remove CloseChanInit from transfer

* add changelog

Co-authored-by: Aditya <adityasripal@gmail.com>
@dependabot
Bump codecov/codecov-action from 2.0.1 to 2.0.2 (#296)
6f10a68 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 2.0.1 to 2.0.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md)
- [Commits](codecov/codecov-action@v2.0.1...v2.0.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/spf13/cast from 1.3.1 to 1.4.0 (#301)
da40d55 
Bumps [github.com/spf13/cast](https://github.com/spf13/cast) from 1.3.1 to 1.4.0.
- [Release notes](https://github.com/spf13/cast/releases)
- [Commits](spf13/cast@v1.3.1...v1.4.0)

---
updated-dependencies:
- dependency-name: github.com/spf13/cast
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump technote-space/get-diff-action from 4.2 to 5 (#306)
11da3d7 
Bumps [technote-space/get-diff-action](https://github.com/technote-space/get-diff-action) from 4.2 to 5.
- [Release notes](https://github.com/technote-space/get-diff-action/releases)
- [Changelog](https://github.com/technote-space/get-diff-action/blob/main/.releasegarc)
- [Commits](technote-space/get-diff-action@v4.2...v5)

---
updated-dependencies:
- dependency-name: technote-space/get-diff-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@AdityaSripal
do handshake logic, create test file
7b51ebd
@colin-axner
bump to SDK v0.43.0-rc3 (#308)
bf508c6 
* SDK v0.43.0-rc3

* add capability fixes
@AdityaSripal
do cap logic and fix build
150211d
@colin-axner
add @seantking as codeowner to interchain accounts (#309)
3642983
@charleenfei
Merge remote-tracking branch 'upstream/main' into ics29-fee-middleware
bb9063b
@dependabot
Bump google.golang.org/grpc from 1.39.0 to 1.39.1 (#320)
6c3b582 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.0 to 1.39.1.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.39.0...v1.39.1)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump github.com/cosmos/cosmos-sdk from 0.43.0-rc3 to 0.43.0 (#325)
1160f56 
Bumps [github.com/cosmos/cosmos-sdk](https://github.com/cosmos/cosmos-sdk) from 0.43.0-rc3 to 0.43.0.
- [Release notes](https://github.com/cosmos/cosmos-sdk/releases)
- [Changelog](https://github.com/cosmos/cosmos-sdk/blob/master/CHANGELOG.md)
- [Commits](cosmos/cosmos-sdk@v0.43.0-rc3...v0.43.0)

---
updated-dependencies:
- dependency-name: github.com/cosmos/cosmos-sdk
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@alexanderbez @colin-axner
module: improve 04-channel logging (#323)
3dade92 
* module: improve 04-channel logging

* update log

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@colin-axner
update changelog (#326)
632d71f
@charleenfei
Merge remote-tracking branch 'upstream/main' into feat/ics29_packet_c…
c561377 
…allbacks
@charleenfei
Merge branch 'aditya/handshake' into feat/ics29_packet_callbacks
e4e0339
@charleenfei
initial scaffolding
fc6ed02
@charleenfei charleenfei changed the base branch from main to ics29-fee-middleware August 12, 2021 10:47
@codecov-commenter
Copy link

Codecov Report

Merging #331 (fc6ed02) into ics29-fee-middleware (158a251) will decrease coverage by 1.32%.
The diff coverage is 15.17%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##           ics29-fee-middleware     #331      +/-   ##
========================================================
- Coverage                 78.84%   77.52%   -1.33%     
========================================================
  Files                       117      122       +5     
  Lines                      9590     9774     +184     
========================================================
+ Hits                       7561     7577      +16     
- Misses                     1647     1815     +168     
  Partials                    382      382
Impacted Files Coverage Δ
modules/apps/29-fee/keeper/ics4-callbacks.go 0.00% <0.00%> (ø)
modules/apps/29-fee/keeper/keeper.go 0.00% <0.00%> (ø)
modules/apps/29-fee/module.go 0.00% <0.00%> (ø)
modules/apps/29-fee/types/keys.go 0.00% <0.00%> (ø)
modules/apps/transfer/keeper/keeper.go 94.28% <ø> (ø)
modules/core/04-channel/keeper/packet.go 96.02% <100.00%> (+0.07%) ⬆️
modules/core/04-channel/types/version.go 100.00% <100.00%> (ø)
... and 3 more

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request introduces 1 alert when merging fc6ed02 into 632d71f - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request introduces 1 alert when merging fc6ed02 into 158a251 - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@dependabot
Bump google.golang.org/grpc from 1.39.1 to 1.40.0 (#332)
2c5ea11 
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.39.1 to 1.40.0.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.39.1...v1.40.0)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@colin-axner
Copy link
Contributor

I updated ics29-fee-middleware to the latest changes of main, so I think rebasing off of ics29-fee-middleware should get rid of the diffs that were introduced into main by other prs. For future reference I'd branch off of ics29-fee-middleware when making a pr into that branch so commits to main aren't included in the pr review

@lgtm-com
Copy link

lgtm-com bot commented Aug 12, 2021

This pull request introduces 1 alert when merging 647e74e into c63af4a - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@thomas-nguy thomas-nguy mentioned this pull request Aug 27, 2021
Closed
3 tasks
@colin-axner
Copy link
Contributor

colin-axner commented Aug 27, 2021 •
edited
Loading

It might be easier to fix the diffs by creating a new branch off ics29-fee-middleware and then using git cherry-pick to move your commit over to the new branch

@lgtm-com
Copy link

lgtm-com bot commented Aug 27, 2021

This pull request introduces 1 alert when merging 830fb20 into c63af4a - view on LGTM.com

new alerts:

  • 1 for Useless assignment to local variable

@charleenfei charleenfei deleted the feat/ics29_packet_callbacks branch August 27, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@charleenfei @codecov-commenter @colin-axner @AdityaSripal @alexanderbez