Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 8 Interface and Packet Data Implementations #3287

Merged
merged 12 commits into from
Mar 29, 2023

Commits on Mar 13, 2023

  1. Configuration menu
    Copy the full SHA
    bf93c0e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8c16e8d View commit details
    Browse the repository at this point in the history
  3. documentation

    AdityaSripal committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    3500d06 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. Configuration menu
    Copy the full SHA
    89f608c View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Configuration menu
    Copy the full SHA
    b77cfe6 View commit details
    Browse the repository at this point in the history
  2. add ica tests

    AdityaSripal committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    1db4626 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    32b74ec View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. adr 8 callback packet data impl followups (#3325)

    * remove query client (#3227)
    
    * remove query client
    
    * merge main
    
    * go mod tidy
    
    * Rename ``IsBound`` to ``HasCapability`` (#3253)
    
    ## Description
    
    
    
    closes: #828
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    imp(api!): rename `IsBound` to `HasCapability` for IBC application modules
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [x] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [ ] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    
    * chore: add support for tendermint debug log level (#3279)
    
    * build(deps): bump cosmossdk.io/math from 1.0.0-beta.6.0.20230216172121-959ce49135e4 to 1.0.0-rc.0 (#3285)
    
    Bumps [cosmossdk.io/math](https://github.com/cosmos/cosmos-sdk) from 1.0.0-beta.6.0.20230216172121-959ce49135e4 to 1.0.0-rc.0.
    <details>
    <summary>Commits</summary>
    <ul>
    <li>See full diff in <a href="https://github.com/cosmos/cosmos-sdk/commits/math/v1.0.0-rc.0">compare view</a></li>
    </ul>
    </details>
    <br />
    
    
    [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cosmossdk.io/math&package-manager=go_modules&previous-version=1.0.0-beta.6.0.20230216172121-959ce49135e4&new-version=1.0.0-rc.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
    
    Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
    
    [//]: # (dependabot-automerge-start)
    [//]: # (dependabot-automerge-end)
    
    ---
    
    <details>
    <summary>Dependabot commands and options</summary>
    <br />
    
    You can trigger Dependabot actions by commenting on this PR:
    - `@dependabot rebase` will rebase this PR
    - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
    - `@dependabot merge` will merge this PR after your CI passes on it
    - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
    - `@dependabot cancel merge` will cancel a previously requested merge and block automerging
    - `@dependabot reopen` will reopen this PR if it is closed
    - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
    - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
    - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    
    
    </details>
    
    * Write docker inspect output to diagnostics (#3291)
    
    * chore: fix dead links (#3293)
    
    ## Description
    
    
    
    closes: #XXXX
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    type: commit message
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [x] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [x] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    
    * build(deps): bump google.golang.org/protobuf from 1.29.0 to 1.29.1 (#3292)
    
    * deps: bump SDK v0.47 (#3295)
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    
    * remove unnecessary import from doc
    
    * chore: remove support for v3 (#3294)
    
    * build(deps): bump actions/setup-go from 3 to 4 (#3307)
    
    * imp: remove unnecessary defer func statements (#3304)
    
    * Remove gogoproto yaml tags from proto files (#3290)
    
    ## Description
    Refer from original issue, I removed all `yaml` tags in proto files.
    
    closes: #3145 
    
    
    ### Commit Message / Changelog Entry
    
    ```bash
    type: commit message
    ```
    
    see the [guidelines](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) for commit messages. (view raw markdown for examples)
    
    
    
    
    ---
    
    Before we can merge this PR, please make sure that all the following items have been
    checked off. If any of the checklist items are not applicable, please leave them but
    write a little note why.
    
    - [ ] Targeted PR against correct branch (see [CONTRIBUTING.md](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#pull-request-targeting)).
    - [ ] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
    - [ ] Code follows the [module structure standards](https://github.com/cosmos/cosmos-sdk/blob/main/docs/docs/building-modules/10-structure.md) and [Go style guide](../docs/dev/go-style-guide.md).
    - [ ] Wrote unit and integration [tests](https://github.com/cosmos/ibc-go/blob/main/testing/README.md#ibc-testing-package).
    - [ ] Updated relevant documentation (`docs/`) or specification (`x/<module>/spec/`).
    - [ ] Added relevant `godoc` [comments](https://blog.golang.org/godoc-documenting-go-code).
    - [ ] Provide a [commit message](https://github.com/cosmos/ibc-go/blob/main/docs/dev/pull-requests.md#commit-messages) to be used for the changelog entry in the PR description for review.
    - [ ] Re-reviewed `Files changed` in the Github PR explorer.
    - [ ] Review `Codecov Report` in the comment section below once CI passes.
    
    * add reasoning for migration to enable localhost
    
    * Support configuration file for e2e tests (#3260)
    
    * E2E fzf Test Selection Autocompletion (#3313)
    
    * post v7 release chores (#3310)
    
    * chore: fix linter warnings (#3311)
    
    * ADR 008: IBC Actor Callbacks (#1976)
    
    * context and decision
    
    * complete adr
    
    * Apply suggestions from code review
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    
    * change from caller to generalized actor
    
    * Apply suggestions from code review
    
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    
    * create folder and scaffolded middleware
    
    * add error handling and generify packetdata interface
    
    * complete renaming
    
    * add user defined gas limit and clarify pseudocode
    
    * Clarify CallbackPacketData interface
    
    imp: Add ADR 008: IBC Actor Callbacks
    
    ---------
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
    
    * lint: fix spelling
    
    * chore: apply self review concerns
    
    * chore: rename CallbackPacketDataI to CallbackPacketData
    
    * chore: finish applying remaining review suggestions
    
    * test: add remaining unit tests for transfer and ica
    
    * test: add unmarshaling test
    
    * imp: address ADR 8 review suggestions (#3319)
    
    
    
    ---------
    
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    
    * Bump interchain test (#3314)
    
    * fix: remove codec registration
    
    * fix: build + linting
    
    * Only run e2e on R4R (#3330)
    
    * fix fork workflows (#3328)
    
    * Revert "Merge branch 'main' of github.com:cosmos/ibc-go into colin/callback-packet-data-impl"
    
    This reverts commit 1c6164b, reversing
    changes made to 6f25b8e.
    
    * chore: add optional interface godoc
    
    * Apply suggestions from code review
    
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    
    * chore: use backticks instead of escape characters in testing
    
    ---------
    
    Co-authored-by: Lặc <67097720+expertdicer@users.noreply.github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Cian Hatton <cian@interchain.io>
    Co-authored-by: Carlos Rodriguez <carlos@interchain.io>
    Co-authored-by: Damian Nolan <damiannolan@gmail.com>
    Co-authored-by: GNaD13 <89174180+GNaD13@users.noreply.github.com>
    Co-authored-by: Hieu Vu <72878483+hieuvubk@users.noreply.github.com>
    Co-authored-by: Aditya <adityasripal@gmail.com>
    9 people authored Mar 27, 2023
    Configuration menu
    Copy the full SHA
    f8298da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f826ddd View commit details
    Browse the repository at this point in the history
  3. fix: merge conflicts

    colin-axner committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    ca33576 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6bf400e View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2023

  1. Configuration menu
    Copy the full SHA
    523f40b View commit details
    Browse the repository at this point in the history