test: e2e localhost test create new channel for existing ica account #3146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
colin-axner
approved these changes
Feb 15, 2023
Comment on lines
+325
to
+326
| events := testsuite.ABCIToSDKEvents(txResp.Events) | ||
| packet, err = ibctesting.ParsePacketFromEvents(events) |
There was a problem hiding this comment.
Pretty nice how this came to be so valuable here! :D
chatton
approved these changes
Feb 16, 2023
Comment on lines
+201
to
+203
| // relayer and channel output is discarded, only a single chain is required | ||
| _, _ = s.SetupChainsRelayerAndChannel(ctx) | ||
| chainA, _ := s.GetChains() |
There was a problem hiding this comment.
Maybe we should create an issue to add a second setup function which only spins up a single chain, could be useful for localhost/non-ibc e2e tests.
There was a problem hiding this comment.
Yeah, definitely agree!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Steps are as follows:
MsgRegisterInterchainAccount(channel open init).ref: #3033
Commit Message / Changelog Entry
NA
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.