test: adding e2e tests for 09-localhost #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
damiannolan
changed the title
damiannolan
commented
Feb 9, 2023
e2e/testsuite/relayer.go
Outdated
| @@ -13,7 +13,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| cosmosRelayerRepository = "ghcr.io/cosmos/relayer" | |||
| cosmosRelayerRepository = "damiannolan/rly" | |||
There was a problem hiding this comment.
This is a custom build pushed to dockerhub for temporary use. It includes type registration of the 09-localhost ClientState so that the relayer can continue to function as normal when querying all client states from a node.
There was a problem hiding this comment.
Type registration in the relayer is performed here
damiannolan
commented
Feb 9, 2023
damiannolan
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei and
chatton
as code owners
chatton
reviewed
Feb 14, 2023
chatton
reviewed
Feb 14, 2023
Tests running in CI now and passing! 🙏 |
crodriguezvega
approved these changes
Feb 15, 2023
There was a problem hiding this comment.
Excellent work, @damiannolan. Specially with handling all the handshake messages!
I left just a couple of potential improvements.
chatton
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #3033
Commit Message / Changelog Entry
NA
see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.