Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit receive addresses to 2kb #2983

Conversation

faddat
Copy link
Contributor

@faddat faddat commented Jan 6, 2023

Description

Adds limitations to the length of ibc receive addresses.

A 2kb size was chosen to preserve the flexible use of the receive address field, where it's just a string and can be interpreted by various modules to trigger other functionality.

TODO:

  • use error conventionally
  • write a test

Commit Message / Changelog Entry

fix: [#2983](https://github.com/cosmos/ibc-go/pull/2983) Limits the receive address length to 2kb

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@faddat faddat changed the title receive Address length limit fix: limit receive addresses to 2kb Jan 6, 2023
@faddat
Copy link
Contributor Author

faddat commented Oct 13, 2023

@crodriguezvega crodriguezvega changed the base branch from main to carlos/4859-unbounded-field-lengths October 15, 2023 22:04
@crodriguezvega crodriguezvega mentioned this pull request Oct 16, 2023
3 tasks
@faddat faddat marked this pull request as ready for review October 19, 2023 16:35
@crodriguezvega crodriguezvega merged commit 075f65f into cosmos:carlos/4859-unbounded-field-lengths Oct 30, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants