Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed unused variables #2692

Merged
merged 6 commits into from
Nov 8, 2022
Merged

removed unused variables #2692

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7b531b9
removed unused variables
Daniyal98 Nov 4, 2022
bfae30f
changelog fix
Daniyal98 Nov 4, 2022
ea2ce19
Merge branch 'main' into daniyal/issue#2486_unused_variables
crodriguezvega Nov 8, 2022
7aea49d
add chanopeninit back and check for no error
crodriguezvega Nov 8, 2022
8873bab
Update CHANGELOG.md
crodriguezvega Nov 8, 2022
790ad88
Merge branch 'main' into daniyal/issue#2486_unused_variables
colin-axner Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* [\#2434](https://github.com/cosmos/ibc-go/pull/2478) Removed all `TypeMsg` constants
* (modules/core/exported) [#1689] (https://github.com/cosmos/ibc-go/pull/2539) Removing `GetVersions` from `ConnectionI` interface.
* (testing) [\#2657](https://github.com/cosmos/ibc-go/pull/2657) Carry `ProposerAddress` through commited blocks. Allow `DefaultGenTxGas` to be modified.
* [\#2486] (https://github.com/cosmos/ibc-go/pull/pull/2692) Removed unused variables from `core/04-channel/keeper/packet_test.go` and `core/04-channel/keeper/handshake_test.go`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need a changelog entry for this change. Since I can edit the file, I will remove it myself.


### Features

Expand Down
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/handshake_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,8 @@ func (suite *KeeperTestSuite) TestChanCloseInit() {
// create channel in init
path.SetChannelOrdered()
err = path.EndpointA.ChanOpenInit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it back and added as well asuite.Require().NoError(err)


suite.Require().NoError(err)

// ensure channel capability check passes
suite.chainA.CreateChannelCapability(suite.chainA.GetSimApp().ScopedIBCMockKeeper, path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
channelCap = suite.chainA.GetChannelCapability(path.EndpointA.ChannelConfig.PortID, path.EndpointA.ChannelID)
Expand Down
9 changes: 2 additions & 7 deletions modules/core/04-channel/keeper/packet_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ var (
defaultTimeoutHeight = clienttypes.NewHeight(1, 100)

// for when the testing package cannot be used
clientIDA = "clientA"
clientIDB = "clientB"
connIDA = "connA"
connIDB = "connB"
portID = "portid"
channelIDA = "channelidA"
channelIDB = "channelidB"
connIDA = "connA"
connIDB = "connB"
)

// TestSendPacket tests SendPacket from chainA to chainB
Expand Down