Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for rc0 release #231

Merged
merged 9 commits into from
Jul 7, 2021
Merged

Conversation

colin-axner
Copy link
Contributor

@colin-axner colin-axner commented Jul 5, 2021

Description

Note: this is against the release branch

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

seantking and others added 2 commits July 5, 2021 12:09
* fix: moving  event to keeper function instead of rpc handler

* refactor: removing unnecessary handler

* refactor: delete channel handler file

* Apply suggestions from code review

Co-authored-by: Aditya <adityasripal@gmail.com>
@colin-axner colin-axner changed the base branch from main to release/v1.0.x July 5, 2021 10:10
colin-axner and others added 4 commits July 6, 2021 16:29
* add missing changelog entries

* add missing entry
* fix to set events to the original context

* Update modules/core/keeper/msg_server.go

Co-authored-by: Aditya <adityasripal@gmail.com>
Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
Co-authored-by: Aditya <adityasripal@gmail.com>
* fix sentinel value

* add godoc and test

* fix grammar

* add changelog

Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
@colin-axner colin-axner marked this pull request as ready for review July 6, 2021 14:55
@codecov-commenter
Copy link

Codecov Report

Merging #231 (449847b) into release/v1.0.x (2e95805) will increase coverage by 0.13%.
The diff coverage is 87.83%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v1.0.x     #231      +/-   ##
==================================================
+ Coverage           79.33%   79.46%   +0.13%     
==================================================
  Files                 115      115              
  Lines                6746     6838      +92     
==================================================
+ Hits                 5352     5434      +82     
- Misses               1016     1026      +10     
  Partials              378      378              
Impacted Files Coverage Δ
...ght-clients/07-tendermint/types/consensus_state.go 100.00% <ø> (ø)
modules/core/keeper/msg_server.go 64.94% <73.52%> (+0.94%) ⬆️
modules/apps/transfer/keeper/relay.go 88.70% <100.00%> (ø)
modules/core/02-client/keeper/client.go 98.56% <100.00%> (ø)
modules/core/02-client/keeper/proposal.go 92.15% <100.00%> (ø)
modules/core/04-channel/keeper/handshake.go 88.36% <100.00%> (+2.37%) ⬆️
...dules/light-clients/07-tendermint/types/upgrade.go 72.88% <100.00%> (ø)

…#241)

* ensure latest height revision number matches chain id revision number

fix tests as well

* add changelog

* Update modules/light-clients/07-tendermint/types/client_state_test.go

* Update modules/light-clients/07-tendermint/types/client_state_test.go

* address review suggestions
@colin-axner colin-axner changed the title prepare for beta2 release prepare for rc0 release Jul 7, 2021
@colin-axner colin-axner merged commit 9982478 into release/v1.0.x Jul 7, 2021
@colin-axner colin-axner deleted the colin/beta2-release-prep branch July 7, 2021 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants