Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sdk.Result from application callbacks #215 #227

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

smadarasmi
Copy link
Contributor

Description

Closes #215 by removing sdk.Result from the IBC Module
-->

closes: #215


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this needs a changelog entry and an entry in the migration docs for going from ibc-go 1.0 -> 2.0 (this will not be included in 1.0)

I will try to push these to this branch

@colin-axner
Copy link
Contributor

I was unable to push to your branch so I made a pr

Thanks for the contribution

add changelog and migration doc entry
@smadarasmi
Copy link
Contributor Author

@colin-axner Thanks for the prompt feedback. I've merged ur PR into this branch. Please let me know if any other issues.

@colin-axner colin-axner enabled auto-merge (squash) July 5, 2021 14:20
@colin-axner
Copy link
Contributor

Thanks again for the contribution @smadarasmi! The pr is ready for auto merge

@colin-axner colin-axner merged commit b36f8c6 into cosmos:main Jul 5, 2021
faddat referenced this pull request in notional-labs/ibc-go Feb 23, 2022
Cleanup dockerfile and add coral support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove sdk.Result from application callbacks
2 participants