ibc-go v3.1.0 with sdk 46 #1707
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faddat
requested review from
seantking,
colin-axner,
AdityaSripal,
damiannolan,
fedekunze,
crodriguezvega and
charleenfei
as code owners
…v3.1 to determine
|
hey @faddat, thanks a lot for opening this PR. Let's work together to get this passing the tests as soon as possible! 👍 Can you please rebase your branch with the branch release/v3.3.x and target the PR against the branch release/v3.3.x? I think some tests are failing now because the require go 1.18 and release/v3.1.x is using go 1.17. We will most likely release the upgrade to SDK 0.46 as v3.3.0. There is already a release/v3.2.x but that will be used to continue releasing new patch versions of SDK 0.45. |
|
got it! yeah happy to do so. Will get on that now. |
|
For the sake of convenience, I'm just going to close this pull request and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'd like to get this into a tagged release form after review
This is a notional-umee collaboration.
On today's cosmos SDK call there was some lamentation of the lack of 46 support, and Robert pointed out something pretty important to me: the v4/main I am building against in #1653 isn't yet stable and that could lead to yet more unplesantry.
Robert got this kicked off, and I finished it up. Should be a nice, stable solution for using 46, and I have a specific ask:
can we please tag this so that those of us working with 46 do not need to litter go.mod with a bunch of replace statements?
I was thinking something like:
v3.1.0-46
Cant targeta a PR to a branch that doesn't exist, but might also be a good idea to make a branch like:
release/v3.1.0-46
The list of teams attempting to use 46 and hitting friction because there's not a tagged release of ibc-go that supports 46 is long and getting longer.
....and more
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes