change FrozenSequence to boolean in solo machine #169
Conversation
| return exported.Frozen | ||
| } | ||
|
|
||
| return exported.Active | ||
| } | ||
|
|
||
| // IsFrozen returns true if the client is frozen. | ||
| func (cs ClientState) IsFrozen() bool { |
There was a problem hiding this comment.
This should have been deleted in the Status pr
There was a problem hiding this comment.
Have you removed it from localhost?
There was a problem hiding this comment.
yup, I think this one got added back during a merge of main when I fixed the solo machine bug
| // GetFrozenHeight returns the frozen sequence of the client. | ||
| // Return exported.Height to satisfy interface | ||
| // Revision number is always 0 for a solo-machine | ||
| func (cs ClientState) GetFrozenHeight() exported.Height { | ||
| return clienttypes.NewHeight(0, cs.FrozenSequence) | ||
| return clienttypes.NewHeight(0, 1) |
There was a problem hiding this comment.
this will be removed by #165
| @@ -445,10 +440,6 @@ func produceVerificationArgs( | |||
| } | |||
| // sequence is encoded in the revision height of height struct | |||
| sequence := height.GetRevisionHeight() | |||
| if cs.IsFrozen() { | |||
There was a problem hiding this comment.
should have been removed by Status pr, this is checked in 02-client
| @@ -16,7 +16,7 @@ message ClientState { | |||
| // latest sequence of the client state | |||
| uint64 sequence = 1; | |||
| // frozen sequence of the solo machine | |||
| uint64 frozen_sequence = 2 [(gogoproto.moretags) = "yaml:\"frozen_sequence\""]; | |||
| bool is_frozen = 2 [(gogoproto.moretags) = "yaml:\"is_frozen\""]; | |||
There was a problem hiding this comment.
this is proto breaking. Should I make a v2? @AdityaSripal @fedekunze
There was a problem hiding this comment.
I could alternatively deprecate the frozen sequence field and add a new field is_frozen
There was a problem hiding this comment.
Going to try to do a v2. I think it is good practice
There was a problem hiding this comment.
Cool, I just changed the package from v1 -> v2
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 79.90% 79.89% -0.02%
==========================================
Files 107 107
Lines 6420 6415 -5
==========================================
- Hits 5130 5125 -5
Misses 932 932
Partials 358 358
|
fixed changelog, removed GetFrozenHeight solo machine function
| return exported.Frozen | ||
| } | ||
|
|
||
| return exported.Active | ||
| } | ||
|
|
||
| // IsFrozen returns true if the client is frozen. | ||
| func (cs ClientState) IsFrozen() bool { |
There was a problem hiding this comment.
Have you removed it from localhost?
Description
This will be a lot easier to do now since the solo machine was broken and we don't have to worry about backwards compatibility
closes: #36
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes