Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: emitting an event when handling a client upgrade proposal (backport #1570) #1593

Merged
merged 4 commits into from
Jul 5, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 27, 2022

This is an automatic backport of pull request #1570 done by Mergify.
Cherry-pick of 8422d0c has failed:

On branch mergify/bp/release/v3.0.x/pr-1570
Your branch is up to date with 'origin/release/v3.0.x'.

You are currently cherry-picking commit 8422d0c.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   modules/core/02-client/keeper/events.go
	modified:   modules/core/02-client/keeper/proposal.go
	modified:   modules/core/02-client/types/events.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   CHANGELOG.md

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* feat: emitting an event when handling a client upgrade proposal

* refactor: only emit event if err is nil

* refactor: idiotmatic go:

(cherry picked from commit 8422d0c)

# Conflicts:
#	CHANGELOG.md
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@crodriguezvega crodriguezvega merged commit b91ef4e into release/v3.0.x Jul 5, 2022
@crodriguezvega crodriguezvega deleted the mergify/bp/release/v3.0.x/pr-1570 branch July 5, 2022 07:56
dudong2 pushed a commit to dudong2/ibc-go that referenced this pull request Jan 19, 2023
…port cosmos#1570) (cosmos#1593)

* feat: emitting an event when handling a client upgrade proposal (cosmos#1570)

* feat: emitting an event when handling a client upgrade proposal

* refactor: only emit event if err is nil

* refactor: idiotmatic go:

(cherry picked from commit 8422d0c)

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: Sean King <seantking@users.noreply.github.com>
Co-authored-by: Damian Nolan <damiannolan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants