feat: emitting an event when handling a client upgrade proposal (backport #1570) #1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* feat: emitting an event when handling a client upgrade proposal * refactor: only emit event if err is nil * refactor: idiotmatic go: (cherry picked from commit 8422d0c) # Conflicts: # CHANGELOG.md # modules/core/02-client/keeper/events.go
mergify
bot
requested review from
colin-axner,
fedekunze,
AdityaSripal,
crodriguezvega,
seantking,
charleenfei and
damiannolan
as code owners
seantking
reviewed
Jun 30, 2022
seantking
approved these changes
Jun 30, 2022
damiannolan
reviewed
Jun 30, 2022
CHANGELOG.md
Outdated
| @@ -46,6 +46,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ | |||
| * (modules/core/keeper) [\#1284](https://github.com/cosmos/ibc-go/pull/1284) Add sanity check for the keepers passed into `ibckeeper.NewKeeper`. `ibckeeper.NewKeeper` now panics if any of the keepers passed in is empty. | |||
| * (transfer) [\#1414](https://github.com/cosmos/ibc-go/pull/1414) Emitting Sender address from `fungible_token_packet` events in `OnRecvPacket` and `OnAcknowledgementPacket`. | |||
| * (modules/core/04-channel) [\#1464](https://github.com/cosmos/ibc-go/pull/1464) Emit a channel close event when an ordered channel is closed. | |||
| * (core/02-client) [\#1570](https://github.com/cosmos/ibc-go/pull/1570) Emitting an event when handling an upgrade client proposal. | |||
There was a problem hiding this comment.
Shouldn't this be in the unreleased section at the top of changelog? i.e. targeted for v2.1.2
seantking
force-pushed
the
mergify/bp/release/v2.1.x/pr-1570
branch
from
f5b8b3b
to
6171dd3
Compare
seantking
reviewed
Jun 30, 2022
damiannolan
approved these changes
Jun 30, 2022
| ) | ||
|
|
||
| // EmitCreateClientEvent emits a create client event | ||
| func EmitCreateClientEvent(ctx sdk.Context, clientID string, clientState exported.ClientState) { |
There was a problem hiding this comment.
I see that all these other Emit... functions were added as part of #783, but not back ported to any of the v2 release lines, so if we add then in this PR they are actually not used in the code. Should we remove then so that we also keep closer to the spirit of the PR that is being back ported here?
We have this problem in the other v2 back ports as well...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #1570 done by Mergify.
Cherry-pick of 8422d0c has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com