Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: overview of fee middleware #1549

Merged
merged 4 commits into from
Jun 16, 2022
Merged

docs: overview of fee middleware #1549

merged 4 commits into from
Jun 16, 2022

Conversation

charleenfei
Copy link
Contributor

Description

Cherrypicks #1524

closes: #1407

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

chatton
chatton approved these changes Jun 16, 2022
View reviewed changes
Copy link
Contributor

@chatton chatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

damiannolan
damiannolan approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! The first PR was to the old feature branch, missed that!

@crodriguezvega crodriguezvega merged commit 1be4519 into main Jun 16, 2022
@crodriguezvega crodriguezvega deleted the docs/overview_fee_middleware branch June 16, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damiannolan damiannolan damiannolan approved these changes

@chatton chatton chatton approved these changes

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@AdityaSripal AdityaSripal Awaiting requested review from AdityaSripal AdityaSripal is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@seantking seantking Awaiting requested review from seantking

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

overview of fee middleware
4 participants
@charleenfei @damiannolan @chatton @crodriguezvega