Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport update Makefile with buf fixes (#213) #1490

Merged
merged 1 commit into from
Jun 7, 2022

Conversation

crodriguezvega
Copy link
Contributor

@crodriguezvega crodriguezvega commented Jun 6, 2022

Description

When trying to backport #1416 to release/v1.5.x I run into problems with make proto-gen. I think the fixes in #213 will solve the problems and let me regenerate the proto files.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

* update Makefile with buf fixes

* update makefile with changes from SDK
@crodriguezvega crodriguezvega changed the title update Makefile with buf fixes (#213) backport update Makefile with buf fixes (#213) Jun 6, 2022
@crodriguezvega crodriguezvega merged commit 983832f into release/v1.5.x Jun 7, 2022
@crodriguezvega crodriguezvega deleted the carlos/backport-213-to-v1.5.x branch June 7, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants