refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn #1188
Conversation
seantking
requested review from
colin-axner,
fedekunze and
AdityaSripal
as code owners
| @@ -79,6 +79,8 @@ func (k Keeper) UpgradeClient(goCtx context.Context, msg *clienttypes.MsgUpgrade | |||
| } | |||
|
|
|||
| // SubmitMisbehaviour defines a rpc handler method for MsgSubmitMisbehaviour. | |||
| // Warning: DEPRECATED | |||
There was a problem hiding this comment.
Is that what you meant @colin-axner ?
There was a problem hiding this comment.
I think it would be good to add a deprecation notice to the proto files for MsgSubmitBehaviour.
Unfortunately protobuf only seems to have the field option [deprecated = true], there isn't any concrete deprecation flags for an entire message type.
There was a problem hiding this comment.
Yeah great point, thanks.
There was a problem hiding this comment.
Done: see #1188 (comment)
| @@ -47,11 +47,11 @@ enum ResponseResultType { | |||
| option (gogoproto.goproto_enum_prefix) = false; | |||
|
|
|||
| // Default zero value enumeration | |||
| RESPONSE_RESULT_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "UNSPECIFIED"]; | |||
| RESPONSE_RESULT_TYPE_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "UNSPECIFIED"]; | |||
There was a problem hiding this comment.
I copied over the changes that are on main. There is some linting issues for channel protos on the 02-client-refactor branch that are fixed on main. In order to add the deprecated flag for MsgSubmitMisbehavior I fixed this (the linter was failing otherwise).
There was a problem hiding this comment.
Nice 👍 I fixed this on main in #1143 before but I think those changes have been pulled into 02-client-refactor yet.
I think we should probably merge the latest of main in, also includes the fixes for gh actions (link checker)
seantking
force-pushed
the
sean/issue#880-route-submit-misb-to-update-client
branch
from
7a14e35
to
614d818
Compare
| @@ -82,16 +82,17 @@ message MsgUpgradeClientResponse {} | |||
|
|
|||
| // MsgSubmitMisbehaviour defines an sdk.Msg type that submits Evidence for | |||
| // light client misbehaviour. | |||
| // Warning: DEPRECATED | |||
There was a problem hiding this comment.
Should we add something like: "Use MsgUpdateClient instead, this will be removed in a future release"
…sb-to-update-client
…smos#1188) * refactor: routing MsgSubmitMisbehaviour to UpdateClient keeper fn * chore: updating changelog and comment for deprecated notice * fix: channel proto file linter issue + adding deprecated flag to MsgSubmitMisbehavior * chore: fix changelog
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview Closes: cosmos#1180 <!-- Please provide an explanation of the PR, including the appropriate context, background, goal, and rationale. If there is an issue with this information, please provide a tl;dr and link the issue. --> ## Checklist <!-- Please complete the checklist to ensure that the PR is ready to be reviewed. IMPORTANT: PRs should be left in Draft until the below checklist is completed. --> - [x] New and updated code has appropriate documentation - [x] New and updated code has new and/or updated testing - [x] Required CI checks are passing - [ ] Visual proof for any user facing features like CLI or documentation updates - [x] Linked issues closed with keywords
Description
closes: #880
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes