Add counterpartyChannelId param to IBCModule.OnChanOpenAck #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catShaark
requested review from
seantking,
colin-axner,
AdityaSripal,
damiannolan,
fedekunze,
crodriguezvega and
charleenfei
as code owners
catShaark
changed the title
catShaark
force-pushed
the
add-CounterpartyChannelID-to-IBCModule-OnChanOpenAck
branch
from
c25e5ee
to
bec3560
Compare
colin-axner
reviewed
Mar 8, 2022
Comment on lines
54
to
+55
| counterpartyVersion string, | ||
| counterpartyChannelID string, |
There was a problem hiding this comment.
could you change the ordering such that counterpartyChannelID comes before counterpartyVersion? See proposed spec changes?
There was a problem hiding this comment.
Thanks for the contribution!
This needs a changelog entry under the API breaking section and an addition to the
docs/v2-to-v3.mdmigrations docs, but I can add both in a followup pr if you feel uncertain about adding that
I can make the pr
There was a problem hiding this comment.
#1086 I just made this pr
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
=======================================
Coverage 79.81% 79.81%
=======================================
Files 151 151
Lines 10882 10882
=======================================
Hits 8685 8685
Misses 1774 1774
Partials 423 423
|
|
issue closed by #1086 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ref: #1075
I add counterpartyChannelID as a param to IBCModule.OnChanOpenAck to support ibc module that use counterpartyChannelID in their OnChanOpenAck logic. #1075
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes