Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use string for address in NewMsg constructors #73

Closed
colin-axner opened this issue Mar 5, 2021 · 0 comments · Fixed by #108
Closed

use string for address in NewMsg constructors #73

colin-axner opened this issue Mar 5, 2021 · 0 comments · Fixed by #108
Assignees
@colin-axner
Labels
20-transfer core
Milestone
1.0.0

Comments

@colin-axner
Copy link
Contributor

Do proposed fixed in 8332 for IBC modules
@colin-axner colin-axner changed the title Deal with address.String() concerns use string for address in NewMsg constructors Mar 5, 2021
@colin-axner colin-axner added this to the 1.1.0 milestone Mar 16, 2021
@colin-axner colin-axner self-assigned this Apr 7, 2021
@colin-axner colin-axner mentioned this issue Apr 8, 2021
Merged
9 tasks
faddat referenced this issue in notional-labs/ibc-go Mar 1, 2022
@jhernandezb
Merge PR #73: Add rocketzone to integration tests 🚀 🌔
5e71020 
* added rocketzone integration tests

* fix badge link

* fixed linter

* add streaming test

* fixed streaming test for rocketzone
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
@tzdybal
Protobuf definition for Optimint types (cosmos#73)
3bd96a4 
Protobuf definition for Optimint types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-axner colin-axner

Labels
20-transfer core
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Modify all message constructors to take in a string for address cosmos/ibc-go
1 participant
@colin-axner