Move event emissions to functions

[colin-axner]

Summary

For all core IBC event emissions, we should put them in functions within their respective keepers, like so

It increases readability of the critical code, provides self documentation, and allows us to ensure consistency between event emission

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[nir1218]

@colin-axner @crodriguezvega Hey, I would like to work on this issue, kindly assign it to me.

[crodriguezvega]

hey @nir1218, glad to see that you want to work on another one. Thanks for dedicating your time to it!

[colin-axner]

@nir1218 let us know if you have any questions

[nir1218]

@crodriguezvega @colin-axner I noticed that in msg_server.go in the upgrade and update client methods there is an emit event of a message type , and then in the client keeper there is an emit of the operation type itself. So my question is, should I consolidate both emissions in one method and invoke it from the client keeper as done in events.go under channel module?

[crodriguezvega]

Yes, I think that makes sense. So, for example, for the case of update client to have a method that emits both this event and this event, right?

Do you agree, @colin-axner?

[colin-axner]

Yes that makes sense to me

[nir1218]

@crodriguezvega @colin-axner Will you be closing the issue and the PR? Is there anything else I can do on this?