-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update tendermint to v0.35 #539
Comments
Thank you for the heads-up Carlos, appreciate that! For completeness, on the Hermes side there are (at least) two specific points we want to address wrt upgrading to tm-go 0.35:
|
* Charge gas for custom event attributes * Introduce gas register for gas costs * Review feedback * Tests and minor updates * Godoc
Since SDK 0.46 will be released with Tendermint 0.34, I am putting this issue on hold for now back in the backlog. We will pick it up again when SDK team plans to release a version with Tendermint 0.35. |
Closing this since Tendermint 0.35 has been discontinued. |
Cancellable contexts are use for proper node shutdown.
Summary
Tendermint has released v0.35. I did a quick check and seems like it introduces some code breaking changes in ibc-go. Maybe we can wait for SDK to release a version that also upgrades Tendermint to v0.35 before we upgrade.
Tendermint v0.35 has breaking changes for hermes, so we need to align with them when we do this.
cc: @adizere
For Admin Use
The text was updated successfully, but these errors were encountered: