Validate connection id associated with channel matches ids in controller port-id

[seantking]

Summary

We need to do a check during the OnChanOpenTry step to validate that the connection-id/counterparty connection id given in the controller side port-id match the connection-ids associated with the current channel. e.g. ics27-1-<connection-id>-<counterparty-connection-id>-<address>

You can use the channelkeeper to check for the current connection-id/counterparty connection-id associated with the current channel. We should return an error if the connection-ids do no match.

Problem Definition

We need to do this check to ensure that a controller chain cannot steal the port-id namespace from another controller chain (which is handled via the connection-ids).

---

For Admin Use

• Not duplicate issue
• Appropriate labels applied
• Appropriate contributors tagged/assigned

[damiannolan]

Closed by #454