Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update SendPacket API to use new Timeout type #3727

Closed
3 tasks
charleenfei opened this issue Jun 1, 2023 · 3 comments
Closed
3 tasks

update SendPacket API to use new Timeout type #3727

charleenfei opened this issue Jun 1, 2023 · 3 comments
Labels
04-channel change: api breaking Issues or PRs that break Go API (need to be release in a new major version) icebox Issues that we will not address for the time being type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Milestone
v10.0.0

Comments

@charleenfei
Copy link
Contributor

Summary of Bug

Currently, the SendPacket API expects separate timeout height and timeout timestamp parameters. We should update this to use the new Timeout type.

see #3600 as a related issue.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@vishal-kanna
Copy link
Contributor

@charleenfei I would like to work on it

@vishal-kanna vishal-kanna mentioned this issue Jun 2, 2023
Closed
9 tasks
@colin-axner
Copy link
Contributor

I wonder if we should delay implementation on this? It's mostly a code-hygiene issue and it breaks the IBC app API, thus requiring IBC applications to update to the new version of ibc-go before a chain could update. I think it'd make more sense to be a little conservative and wait until we need to break the IBC app API regardless

@crodriguezvega crodriguezvega added the type: refactor Architecture, code or CI improvements that may or may not tackle technical debt. label Jun 21, 2023
@crodriguezvega crodriguezvega added icebox Issues that we will not address for the time being and removed nice-to-have labels Jan 5, 2024
@crodriguezvega crodriguezvega added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Jan 23, 2024
@colin-axner colin-axner mentioned this issue May 16, 2024
Closed
10 tasks
@crodriguezvega crodriguezvega added this to the v10.0.0 milestone Jun 7, 2024
@colin-axner
Copy link
Contributor

Timeouts will be moved to be a single uint64, so the timeout type may be dropped entirely. Timeout checking should also be moved to light clients in #7055

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04-channel change: api breaking Issues or PRs that break Go API (need to be release in a new major version) icebox Issues that we will not address for the time being type: refactor Architecture, code or CI improvements that may or may not tackle technical debt.
Projects
None yet
Milestone
v10.0.0
4 participants
@crodriguezvega @charleenfei @colin-axner @vishal-kanna