Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update NewPacket API to use new Timeout type #3600

Closed
3 tasks
charleenfei opened this issue May 17, 2023 · 5 comments
Closed
3 tasks

update NewPacket API to use new Timeout type #3600

charleenfei opened this issue May 17, 2023 · 5 comments
Labels
04-channel change: api breaking Issues or PRs that break Go API (need to be release in a new major version)

Comments

@charleenfei
Copy link
Contributor

Summary of Bug

Currently, the NewPacket API expects separate timeout height and timeout timestamp parameters. We should update this to use the new Timeout type.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@vishal-kanna
Copy link
Contributor

@charleenfei can you please explain about new TImeout type? is it UpgradeTimeout or anything else?

@crodriguezvega crodriguezvega removed this from the 04-channel upgrades alpha milestone May 23, 2023
@hieuvubk
Copy link
Contributor

Is this issue still available?

@charleenfei
Copy link
Contributor Author

Hi @vishal-kanna, @hieuvubk -- sorry for the delay in reply.

The new Timeout type is referring to this type, which should replace the separate params in the NewPacket API.

Please note that if either of you would like to work on this this issue, the PR should be branched off of main, and as it will be an API breaking change it will only released in the next major release.

@charleenfei charleenfei mentioned this issue Jun 1, 2023
Closed
3 tasks
@crodriguezvega crodriguezvega added the change: api breaking Issues or PRs that break Go API (need to be release in a new major version) label Oct 3, 2023
@shreya0288
Copy link

@charleenfei can I work on this issue?

@shreya0288 shreya0288 mentioned this issue Jul 21, 2024
Closed
@crodriguezvega
Copy link
Contributor

See here for reasoning to close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
04-channel change: api breaking Issues or PRs that break Go API (need to be release in a new major version)
Projects
ibc-go
Status: Done 🥳
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update NewPacket API to use new Timeout type shreya0288/ibc-go
5 participants
@crodriguezvega @charleenfei @vishal-kanna @hieuvubk @shreya0288