Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused keeper funcs Get/SetFeeInEscrow #1039

Closed
3 tasks
damiannolan opened this issue Mar 1, 2022 · 1 comment
Closed
3 tasks

Remove unused keeper funcs Get/SetFeeInEscrow #1039

damiannolan opened this issue Mar 1, 2022 · 1 comment
Assignees
Labels

Comments

@damiannolan
Copy link
Member

Summary

#761 changed the ics29 functionality to store multiple packet fees in state.
The remaining GetFeeInEscrow SetFeeInEscrow (note: singular) functions should be removed.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged/assigned
@crodriguezvega
Copy link
Contributor

Closed by #1044

@crodriguezvega crodriguezvega added this to the Fee Middleware milestone Mar 7, 2022
CosmosCar pushed a commit to caelus-labs/ibc-go that referenced this issue Nov 6, 2023
…cosmos#1039)

Bumps
[github.com/celestiaorg/go-fraud](https://github.com/celestiaorg/go-fraud)
from 0.1.0 to 0.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/celestiaorg/go-fraud/releases">github.com/celestiaorg/go-fraud's
releases</a>.</em></p>
<blockquote>
<h2>v0.1.1</h2>
<h2>What's Changed</h2>
<ul>
<li>adding verifiers to ProofService by <a
href="https://github.com/gupadhyaya"><code>@​gupadhyaya</code></a> in <a
href="https://redirect.github.com/celestiaorg/go-fraud/pull/5">celestiaorg/go-fraud#5</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/gupadhyaya"><code>@​gupadhyaya</code></a> made
their first contribution in <a
href="https://redirect.github.com/celestiaorg/go-fraud/pull/5">celestiaorg/go-fraud#5</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/celestiaorg/go-fraud/compare/v0.1.0...v0.1.1">https://github.com/celestiaorg/go-fraud/compare/v0.1.0...v0.1.1</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/a9cd22c90675363abe60744a0824c000b5d7c2fd"><code>a9cd22c</code></a>
Merge pull request <a
href="https://redirect.github.com/celestiaorg/go-fraud/issues/5">#5</a>
from gupadhyaya/add_verifier</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/cea9c0c48fe8d11a715828d230dfb77841b7b526"><code>cea9c0c</code></a>
fix error messages, add AddVerifier to Subscribe interface, move tests
to sep...</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/d485d91607ae09ca53de1f0ba8a6b15686443a4d"><code>d485d91</code></a>
Update fraudserv/service.go</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/690bd5555fff86855e0165501e0de15ea5ca4cea"><code>690bd55</code></a>
fix deadlock</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/50e9b5c75de4f7fcab6748ca2e2be6ab1e2ce237"><code>50e9b5c</code></a>
adding lock for verifiers map</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/b8f79a4e3eee1c1abbe9f83d3ef261d2d617401e"><code>b8f79a4</code></a>
moving verifier outside of the Proof interface to ProofService</li>
<li><a
href="https://github.com/celestiaorg/go-fraud/commit/4d3e4cf1806c5aa0d5227d65a44e14b93e4c64cb"><code>4d3e4cf</code></a>
adding state machine verifier to be invoked as part of
Proof.Validate</li>
<li>See full diff in <a
href="https://github.com/celestiaorg/go-fraud/compare/v0.1.0...v0.1.1">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/celestiaorg/go-fraud&package-manager=go_modules&previous-version=0.1.0&new-version=0.1.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

2 participants