Skip to content

Commit

Permalink
chore: add comment about version assignment (#5239)
Browse files Browse the repository at this point in the history
  • Loading branch information
chatton authored Nov 30, 2023
1 parent fa97576 commit b3c5164
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion modules/core/04-channel/keeper/upgrade.go
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ func (k Keeper) ChanUpgradeAck(

// optimistically accept version that TRY chain proposes and pass this to callback for confirmation
// in the crossing hello case, we do not modify version that our TRY call returned and instead enforce
// that both TRY calls returned the same version
// that both TRY calls returned the same version. It is possible that this will fail in the OnChanUpgradeAck
// callback if the version is invalid.
if channel.IsOpen() {
upgrade.Fields.Version = counterpartyUpgrade.Fields.Version
}
Expand Down

0 comments on commit b3c5164

Please sign in to comment.