nit: damian

cosmos · May 7, 2024 · 817198b · 817198b
1 parent 0ac2e98
commit 817198b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/modules/apps/transfer/ibc_module.go b/modules/apps/transfer/ibc_module.go
@@ -112,7 +112,6 @@ func (im IBCModule) OnChanOpenTry(
 	counterparty channeltypes.Counterparty,
 	counterpartyVersion string,
 ) (string, error) {
-	logger := im.keeper.Logger(ctx)
 	if err := ValidateTransferChannelParams(ctx, im.keeper, order, portID, channelID); err != nil {
 		return "", err
 	}
@@ -124,8 +123,7 @@ func (im IBCModule) OnChanOpenTry(
 
 	if counterpartyVersion != types.Version {
 		// Propose the current version
-		logger.Debug(fmt.Sprintf("invalid counterparty version: expected %s, got %s", types.Version, counterpartyVersion))
-		logger.Debug(fmt.Sprintf("proposing the current version: %s", types.Version))
+		im.keeper.Logger(ctx).Debug("invalid counterparty version, proposing current app version", "counterpartyVersion", counterpartyVersion, "version", types.Version)
 		return types.Version, nil
 	}
 

diff --git a/modules/apps/transfer/ibc_module_test.go b/modules/apps/transfer/ibc_module_test.go
@@ -132,7 +132,7 @@ func (suite *TransferTestSuite) TestOnChanOpenTry() {
 			"success", func() {}, nil,
 		},
 		{
-			"success: invalid counterparty version", func() {
+			"success: invalid counterparty version proposes new version", func() {
 				// transfer module will propose the default version
 				counterpartyVersion = "version"
 			}, nil,