Skip to content

Commit

Permalink
nit: add err type for MsgPayPacketFee
Browse files Browse the repository at this point in the history
  • Loading branch information
seantking committed Jan 17, 2022
1 parent a8405f0 commit 7404d37
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions modules/apps/29-fee/types/errors.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ var (
ErrCounterpartyAddressEmpty = sdkerrors.Register(ModuleName, 7, "counterparty address must not be empty")
ErrForwardRelayerAddressNotFound = sdkerrors.Register(ModuleName, 8, "forward relayer address not found")
ErrFeeNotEnabled = sdkerrors.Register(ModuleName, 9, "fee module is not enabled for this channel. If this error occurs after channel setup, fee module may not be enabled")
ErrInvalidFee = sdkerrors.Register(ModuleName, 10, "one or more fees are invalid")
)
4 changes: 2 additions & 2 deletions modules/apps/29-fee/types/msgs.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,12 @@ func (msg MsgPayPacketFee) ValidateBasic() error {

// if any of the fee's are invalid return an error
if !msg.Fee.AckFee.IsValid() || !msg.Fee.ReceiveFee.IsValid() || !msg.Fee.TimeoutFee.IsValid() {
return sdkerrors.ErrInvalidCoins
return ErrInvalidFee
}

// if all three fee's are zero or empty return an error
if msg.Fee.AckFee.IsZero() && msg.Fee.ReceiveFee.IsZero() && msg.Fee.TimeoutFee.IsZero() {
return sdkerrors.ErrInvalidCoins
return ErrInvalidFee
}

return nil
Expand Down

0 comments on commit 7404d37

Please sign in to comment.