Refactor TestWriteUpgradeTry to remove flush status checks (#4430)

cosmos · Aug 24, 2023 · 5b1071d · 5b1071d
1 parent f230633
commit 5b1071d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/.github/workflows/golangci.yml b/.github/workflows/golangci.yml
@@ -17,10 +17,10 @@ jobs:
     steps:
       - uses: actions/setup-go@v4
         with:
-          go-version: '1.20'
+          go-version: '1.21'
       - uses: actions/checkout@v3
       - name: golangci-lint
-        uses: golangci/golangci-lint-action@v3.6.0
+        uses: golangci/golangci-lint-action@v3.7.0
         with:
-          version: v1.53.3
+          version: v1.54.2
           args: --timeout 5m
diff --git a/modules/apps/transfer/simulation/genesis_test.go b/modules/apps/transfer/simulation/genesis_test.go
@@ -73,6 +73,7 @@ func TestRandomizedGenState1(t *testing.T) {
 	}
 
 	for _, tt := range tests {
+		tt := tt
 		require.Panicsf(t, func() { simulation.RandomizedGenState(&tt.simState) }, tt.panicMsg)
 	}
 }
diff --git a/modules/core/04-channel/keeper/upgrade_test.go b/modules/core/04-channel/keeper/upgrade_test.go
@@ -320,14 +320,12 @@ func (suite *KeeperTestSuite) TestWriteUpgradeTry() {
 	)
 
 	testCases := []struct {
-		name                 string
-		malleate             func()
-		hasPacketCommitments bool
+		name     string
+		malleate func()
 	}{
 		{
 			"success with no packet commitments",
 			func() {},
-			false,
 		},
 		{
 			"success with packet commitments",
@@ -337,7 +335,6 @@ func (suite *KeeperTestSuite) TestWriteUpgradeTry() {
 				suite.Require().NoError(err)
 				suite.Require().Equal(uint64(1), sequence)
 			},
-			true,
 		},
 	}
 
@@ -391,10 +388,6 @@ func (suite *KeeperTestSuite) TestWriteUpgradeTry() {
 			}
 
 			ibctesting.AssertEvents(&suite.Suite, expEvents, events)
-
-			if tc.hasPacketCommitments {
-				suite.Require().Equal(types.NOTINFLUSH, channel.FlushStatus)
-			}
 		})
 	}
 }