Missing NextClientSequence, NextConnectionSequence and NextChannelSeq…

…uence in ExportGenesis (#200) * add missing GenesisState field for ibc client, connection and channel * add changelog Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com>
cosmos · May 27, 2021 · 269164c · 269164c
1 parent ddeb58e
commit 269164c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 14 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -38,6 +38,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
 
 ### Bug Fixes
 
+* (core) [\#200](https://github.com/cosmos/ibc-go/pull/200) Fixes incorrect export of IBC identifier sequences. Previously, the next identifier sequence for clients/connections/channels was not set during genesis export. This resulted in the next identifiers being generated on the new chain to reuse old identifiers (the sequences began again from 0).
 * (02-client) [\#192](https://github.com/cosmos/ibc-go/pull/192) Fix IBC `query ibc client header` cli command. Support historical queries for query header/node-state commands.
 * (modules/light-clients/06-solomachine) [\#153](https://github.com/cosmos/ibc-go/pull/153) Fix solo machine proof height sequence mismatch bug.
 * (modules/light-clients/06-solomachine) [\#122](https://github.com/cosmos/ibc-go/pull/122) Fix solo machine merkle prefix casting bug. 

diff --git a/modules/core/02-client/genesis.go b/modules/core/02-client/genesis.go
@@ -60,10 +60,11 @@ func ExportGenesis(ctx sdk.Context, k keeper.Keeper) types.GenesisState {
 		panic(err)
 	}
 	return types.GenesisState{
-		Clients:          genClients,
-		ClientsMetadata:  clientsMetadata,
-		ClientsConsensus: k.GetAllConsensusStates(ctx),
-		Params:           k.GetParams(ctx),
-		CreateLocalhost:  false,
+		Clients:            genClients,
+		ClientsMetadata:    clientsMetadata,
+		ClientsConsensus:   k.GetAllConsensusStates(ctx),
+		Params:             k.GetParams(ctx),
+		CreateLocalhost:    false,
+		NextClientSequence: k.GetNextClientSequence(ctx),
 	}
 }
diff --git a/modules/core/03-connection/genesis.go b/modules/core/03-connection/genesis.go
@@ -23,7 +23,8 @@ func InitGenesis(ctx sdk.Context, k keeper.Keeper, gs types.GenesisState) {
 // ExportGenesis returns the ibc connection submodule's exported genesis.
 func ExportGenesis(ctx sdk.Context, k keeper.Keeper) types.GenesisState {
 	return types.GenesisState{
-		Connections:           k.GetAllConnections(ctx),
-		ClientConnectionPaths: k.GetAllClientConnectionPaths(ctx),
+		Connections:            k.GetAllConnections(ctx),
+		ClientConnectionPaths:  k.GetAllClientConnectionPaths(ctx),
+		NextConnectionSequence: k.GetNextConnectionSequence(ctx),
 	}
 }
diff --git a/modules/core/04-channel/genesis.go b/modules/core/04-channel/genesis.go
@@ -37,12 +37,13 @@ func InitGenesis(ctx sdk.Context, k keeper.Keeper, gs types.GenesisState) {
 // ExportGenesis returns the ibc channel submodule's exported genesis.
 func ExportGenesis(ctx sdk.Context, k keeper.Keeper) types.GenesisState {
 	return types.GenesisState{
-		Channels:         k.GetAllChannels(ctx),
-		Acknowledgements: k.GetAllPacketAcks(ctx),
-		Commitments:      k.GetAllPacketCommitments(ctx),
-		Receipts:         k.GetAllPacketReceipts(ctx),
-		SendSequences:    k.GetAllPacketSendSeqs(ctx),
-		RecvSequences:    k.GetAllPacketRecvSeqs(ctx),
-		AckSequences:     k.GetAllPacketAckSeqs(ctx),
+		Channels:            k.GetAllChannels(ctx),
+		Acknowledgements:    k.GetAllPacketAcks(ctx),
+		Commitments:         k.GetAllPacketCommitments(ctx),
+		Receipts:            k.GetAllPacketReceipts(ctx),
+		SendSequences:       k.GetAllPacketSendSeqs(ctx),
+		RecvSequences:       k.GetAllPacketRecvSeqs(ctx),
+		AckSequences:        k.GetAllPacketAckSeqs(ctx),
+		NextChannelSequence: k.GetNextChannelSequence(ctx),
 	}
 }