Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump sdk commit #391

Merged
merged 8 commits into from
May 7, 2020
Merged

bump sdk commit #391

merged 8 commits into from
May 7, 2020

Conversation

fedekunze
Copy link
Collaborator

@fedekunze fedekunze commented May 6, 2020

Description

bumps sdk commit to b3cada10017d


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze
Copy link
Collaborator Author

@alessio can you update the tests with the changes from cosmos/cosmos-sdk#6108? 🙏

@fedekunze fedekunze removed the R4R label May 6, 2020
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #391 into master will decrease coverage by 0.04%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##           master     #391      +/-   ##
==========================================
- Coverage   70.84%   70.80%   -0.05%     
==========================================
  Files           4        4              
  Lines         542      548       +6     
==========================================
+ Hits          384      388       +4     
- Misses        126      128       +2     
  Partials       32       32              

fedekunze and others added 3 commits May 6, 2020 12:24
Co-authored-by: Alexander Bezobchuk <alexanderbez@users.noreply.github.com>
fedekunze and others added 2 commits May 7, 2020 13:12
* new validate-signatures sub command

* bump to latest sdk commit

* run go mod tidy
@fedekunze fedekunze requested review from zmanian and cwgoes May 7, 2020 17:18
@alessio alessio merged commit bde5e9c into master May 7, 2020
@alessio alessio deleted the bump-sdk-commit branch May 7, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants