Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ibc v2 test #1021

Closed
wants to merge 19 commits into from
Closed

Ibc v2 test #1021

wants to merge 19 commits into from

Conversation

yaruwangway
Copy link
Contributor

@yaruwangway yaruwangway commented Oct 13, 2021

Closes: #XXX

Description

This PR is for testing ibc-go v2.0.0-rc0.
Router module is removed in this PR.
This PR would not be merged to main.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1021 (69e6656) into main (2947cb5) will increase coverage by 1.71%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1021      +/-   ##
==========================================
+ Coverage   10.44%   12.16%   +1.71%     
==========================================
  Files          11        9       -2     
  Lines        1082      921     -161     
==========================================
- Hits          113      112       -1     
+ Misses        964      804     -160     
  Partials        5        5              

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yaruwangway!!

cc @adizere

@adizere
Copy link

adizere commented Oct 14, 2021

Thanks Yaru, Colin!

I confirm prelimary tests with this binary <> Hermes works. We'd like to keep this branch around for a slightly extended period of time, eg O(weeks) until we finish testing with ibc-go v2, I hope that's OK.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 15, 2021
@yaruwangway
Copy link
Contributor Author

Thanks Yaru, Colin!

I confirm prelimary tests with this binary <> Hermes works. We'd like to keep this branch around for a slightly extended period of time, eg O(weeks) until we finish testing with ibc-go v2, I hope that's OK.

Hi if further test is needed, please checkout release v6.0.0-rc3, and there we use ibc-go v2 with the packet-forward-middleware module (ibc router module).

@stale stale bot removed the stale label Nov 15, 2021
@adizere
Copy link

adizere commented Nov 15, 2021

Thanks Yaru, Colin!
I confirm prelimary tests with this binary <> Hermes works. We'd like to keep this branch around for a slightly extended period of time, eg O(weeks) until we finish testing with ibc-go v2, I hope that's OK.

Hi if further test is needed, please checkout release v6.0.0-rc3, and there we use ibc-go v2 with the packet-forward-middleware module (ibc router module).

Thank you. Confirm we're running with v6.0.0 RCs. Feel free to close this PR.

@Pantani Pantani deleted the ibc-v2-test branch October 13, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants