refactor!: move types to respective folders and remove /types
#639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladjdk
changed the title
/types
aljo242
reviewed
Sep 19, 2025
aljo242
reviewed
Sep 19, 2025
aljo242
reviewed
Sep 19, 2025
There was a problem hiding this comment.
i guess this type of change isn't really proto breaking, its just api breaking
aljo242
reviewed
Sep 19, 2025
|
@vladjdk this lgtm probably best to ship after we finish the config work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
evm/typesserved as a dumping ground for any objects and functions when they were seen to be miscellaneous. The existence of that folder is based on laziness and integrators expressed confusion betweengithub.com/evm/typesandgithub.com/evm/x/vm/types, as their name implies a similar function, when in fact, that was not always the case.closes: #626