-
Notifications
You must be signed in to change notification settings - Fork 104
feat: separate geth metrics server #633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technicallyty
commented
Sep 17, 2025
technicallyty
commented
Sep 17, 2025
technicallyty
commented
Sep 17, 2025
nadim-az
approved these changes
Sep 17, 2025
Eric-Warehime
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs some http Server config settings and formatting. Otherwise lgtm.
…cosmos/evm into technicallyty/metrics-server-geth
Eric-Warehime
added a commit
that referenced
this pull request
Sep 19, 2025
* separate geth metrics server * that should be a wrap * changelog lol * make server behave more like the others * move port to 8100, fix quoting problem * lint fix * expose in dockerfile
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
separating the geth metrics server from the sdk server so it plays more nicely with alloy.
calling this a feat and just updating the changelog line since the previous never made it into a release.
Reviewers
please see my comments below
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
main
branch