Skip to content

Conversation

technicallyty
Copy link
Contributor

@technicallyty technicallyty commented Sep 17, 2025

Description

separating the geth metrics server from the sdk server so it plays more nicely with alloy.

calling this a feat and just updating the changelog line since the previous never made it into a release.

Reviewers

please see my comments below


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@technicallyty technicallyty requested review from a team as code owners September 17, 2025 18:16
@technicallyty technicallyty changed the title refactor: separate geth metrics server feat: separate geth metrics server Sep 17, 2025
Copy link
Contributor

@Eric-Warehime Eric-Warehime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some http Server config settings and formatting. Otherwise lgtm.

@technicallyty technicallyty added this pull request to the merge queue Sep 18, 2025
Merged via the queue into main with commit b63a681 Sep 18, 2025
20 checks passed
@technicallyty technicallyty deleted the technicallyty/metrics-server-geth branch September 18, 2025 16:52
Eric-Warehime added a commit that referenced this pull request Sep 19, 2025
* separate geth metrics server

* that should be a wrap

* changelog lol

* make server behave more like the others

* move port to 8100, fix quoting problem

* lint fix

* expose in dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants