feat!: remove boilerplate code from stateful precompiles #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
changed the title
Solution: - refactor the precompiles code with (hopefully) equivalent transformations. changelog cleanup handle balance handler error return cleanup avoid naked return fix lint fix werc20 fix staking precompile fix panic recovery return error fix staking test case NewPrecompile don't return error
yihuang
force-pushed
the
fix-boilerplates
branch
from
3e12628 to
08a8bef
Compare
yihuang
force-pushed
the
fix-boilerplates
branch
from
84fb275 to
57e77e2
Compare
yihuang
commented
Sep 1, 2025
aljo242
reviewed
Sep 2, 2025
aljo242
changed the title
aljo242
reviewed
Sep 2, 2025
19 tasks
|
@vladjdk will take a look soon! |
|
@yihuang a few conflicts. Apologies for that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #578
Solution:
NativeExecutorinterface to abstract native state logics.NativeExecutorthat prepare the native context and handling gas metering.initfunction instead of runtime.One side effect of this refactor is the order of ABI input parsing and SDK context preparation is switched, other than that, the behavior should be same as before.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch