Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Rpcapi fix - requires Eth namespace #845

Merged
merged 7 commits into from
Mar 16, 2021
Merged

Conversation

araskachoi
Copy link
Contributor

Closes: #835

Description

The code requires the eth namespace for api to run the application. Prior to making the api modular, ALL namespaces have been enabled by default. With the most recent update to the API, #821, the eth api has been removed and is required by the user to include the namespace in the flag (--rpc-api "eth"). This would fix the error that is seen in the ticket this closes.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@freddyli7 freddyli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@araskachoi araskachoi merged commit 2df3abd into development Mar 16, 2021
@araskachoi araskachoi deleted the araska/rpcapi-fix branch March 16, 2021 20:37
@araskachoi araskachoi linked an issue Mar 29, 2021 that may be closed by this pull request
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to subscribe to init.sh
2 participants