Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

faucet: remove module #678

Merged
merged 8 commits into from
Jan 8, 2021
Merged

faucet: remove module #678

merged 8 commits into from
Jan 8, 2021

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Dec 29, 2020

remove faucet module in favor of @cosmjs/faucet

@fedekunze fedekunze marked this pull request as ready for review December 29, 2020 13:47
@fedekunze fedekunze requested a review from noot as a code owner December 29, 2020 13:47
@noot
Copy link
Contributor

noot commented Jan 5, 2021

how does cosmjs work? it seems like it uses a pre-funded account? we should probably discuss this on standup since we'll need to update the existing faucet

@araskachoi
Copy link
Contributor

araskachoi commented Jan 5, 2021

i dont think we ever used the faucet module - i believe we are setting up some "pseudo-faucet" account that just does a value transfer to anyone who requests. I think we have tried to use cosmjs faucet before but was not working for us. There was an issue with the bech32 prefixing and a few other prefixing errs but will try to see if it behaves now (with all the changes we've made)

Copy link
Contributor

@araskachoi araskachoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine! might want to remove references of faucet in the init file and anywhere else (init.sh, init-test-node.sh, etc)

@fedekunze fedekunze merged commit 4a619b1 into development Jan 8, 2021
@fedekunze fedekunze deleted the rm-faucet branch January 8, 2021 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants