This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
Pending #571
Merged
Pending #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 7b49761 into d274c76 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging f6550be into d274c76 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 04486f4 into be09a6e - view on LGTM.com new alerts:
|
noot
reviewed
Dec 15, 2020
noot
reviewed
Dec 15, 2020
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
fedekunze
reviewed
Dec 15, 2020
noot
approved these changes
Dec 15, 2020
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com>
summerpro
reviewed
Dec 17, 2020
| if err := msg.ValidateBasic(); err != nil { | ||
| return nil, err | ||
| // convert the pending transactions into ethermint msgs | ||
| if blockNum == rpctypes.PendingBlockNumber { |
There was a problem hiding this comment.
Why is the pending transaction put in here? My understanding is that only the execution result of one transaction is needed here
| } | ||
|
|
||
| // number of pending txs queried from the mempool | ||
| unconfirmedTxs, err := api.clientCtx.Client.UnconfirmedTxs(1000) |
There was a problem hiding this comment.
What if the actual tx quantity is more than 1000?
There was a problem hiding this comment.
It's highly unlikely (for now) as on the Cosmos Hub there are 1 or 2 avg txs per block.
Closed
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
Description
[x]eth_getBalance
[x]eth_getTransactionCount
[x]eth_getBlockTransactionCountByNumber
[]eth_call
[]eth_estimateGas
[x]eth_getBlockByNumber
0001-01-01 00:00:00 +0000 UTC0x[x]eth_getTransactionByHash
blockNumber = nil[x]eth_getTransactionByBlockNumberAndIndex
blockhash = nilandblocknumber = nil[x]eth_sendTransaction
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)