This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Fix metalinter warnings and add to CI #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@zramsay The linters take to much memory. We only have up to 4GB on CircleCI. Either we have to turn off some linters, upgrade CircleCI to a paid plan or turn of the linting for every PR. What do you think is the best approach? |
zramsay
force-pushed
the
feature/metalinter
branch
from
a0417d7 to
0343c87
Compare
Codecov Report
@@ Coverage Diff @@
## develop #298 +/- ##
========================================
Coverage 24.91% 24.91%
========================================
Files 11 11
Lines 578 578
========================================
Hits 144 144
Misses 410 410
Partials 24 24
Continue to review full report at Codecov.
|
|
We'll turn off for now and wait until someone beef's up the CI across the stack (according to bucky) |
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linting: address some checks * add nolint warnings; remove duplicate megacheck from Makefile * add metalinter to CI, closes #196 * Run metalinter on travis * metalinter: don't run on CI yet
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linting: address some checks * add nolint warnings; remove duplicate megacheck from Makefile * add metalinter to CI, closes #196 * Run metalinter on travis * metalinter: don't run on CI yet
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linting: address some checks * add nolint warnings; remove duplicate megacheck from Makefile * add metalinter to CI, closes #196 * Run metalinter on travis * metalinter: don't run on CI yet
adrianbrink
pushed a commit
that referenced
this pull request
Oct 22, 2017
* linting: address some checks * add nolint warnings; remove duplicate megacheck from Makefile * add metalinter to CI, closes #196 * Run metalinter on travis * metalinter: don't run on CI yet
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #196
ports #297