Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove denom from DenomMetadata key #9890

Merged
merged 7 commits into from
Aug 11, 2021
Merged

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Aug 10, 2021

Description

Closes: #9643


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #9890 (bcc60c7) into master (055e7e8) will increase coverage by 0.00%.
The diff coverage is 76.00%.

❗ Current head bcc60c7 differs from pull request most recent head b1802b2. Consider uploading reports for the commit b1802b2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #9890   +/-   ##
=======================================
  Coverage   63.59%   63.60%           
=======================================
  Files         568      568           
  Lines       53490    53509   +19     
=======================================
+ Hits        34019    34035   +16     
- Misses      17547    17549    +2     
- Partials     1924     1925    +1     
Impacted Files Coverage Δ
x/bank/migrations/v043/keys.go 12.50% <0.00%> (-2.89%) ⬇️
x/bank/types/key.go 82.35% <ø> (+12.35%) ⬆️
x/bank/migrations/v044/store.go 73.68% <85.00%> (+5.26%) ⬆️
x/bank/keeper/keeper.go 72.37% <100.00%> (ø)

@orijbot
Copy link

orijbot commented Aug 10, 2021

@aleem1314 aleem1314 marked this pull request as ready for review August 11, 2021 05:54
@amaury1093 amaury1093 added the T: State Machine Breaking State machine breaking changes (impacts consensus). label Aug 11, 2021
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 11, 2021
@mergify mergify bot merged commit c14b101 into master Aug 11, 2021
@mergify mergify bot deleted the aleem/9643-denom-metadata branch August 11, 2021 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/bank T: State Machine Breaking State machine breaking changes (impacts consensus).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double "Denom" in DenomMetadata key
4 participants