Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: feegrant grant cli bug (backport #9720) #9733

Merged
merged 12 commits into from
Jul 30, 2021

Commits on Jul 20, 2021

  1. fix: feegrant grant cli bug (#9720)

    <!--
    The default pull request template is for types feat, fix, or refactor.
    For other templates, add one of the following parameters to the url:
    - template=docs.md
    - template=other.md
    -->
    
    ## Description
    feegrant grant cli granter now accepts key name as well as address in general and accepts only address in `--generate-only` mode
    
    Closes: #9659
    
    <!-- Add a description of the changes that this PR introduces and the files that
    are the most critical to review. -->
    
    ---
    
    ### Author Checklist
    
    *All items are required. Please add a note to the item if the item is not applicable and
    please add links to any relevant follow up issues.*
    
    I have...
    
    - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [x] added `!` to the type prefix if API or client breaking change
    - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
    - [x] provided a link to the relevant issue or specification
    - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
    - [x] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
    - [x] added a changelog entry to `CHANGELOG.md`
    - [x] included comments for [documenting Go code](https://blog.golang.org/godoc)
    - [x] updated the relevant documentation or specification
    - [ ] reviewed "Files changed" and left comments if necessary
    - [ ] confirmed all CI checks have passed
    
    ### Reviewers Checklist
    
    *All items are required. Please add a note if the item is not applicable and please add
    your handle next to the items reviewed if you only reviewed selected items.*
    
    I have...
    
    - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
    - [ ] confirmed `!` in the type prefix if API or client breaking change
    - [ ] confirmed all author checklist items have been addressed
    - [ ] reviewed state machine logic
    - [ ] reviewed API design and naming
    - [ ] reviewed documentation is accurate
    - [ ] reviewed tests and test coverage
    - [ ] manually tested (if applicable)
    
    (cherry picked from commit 085ab06)
    
    # Conflicts:
    #	CHANGELOG.md
    likhita-809 authored and mergify-bot committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    6833be8 View commit details
    Browse the repository at this point in the history
  2. fix conflicts

    likhita-809 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d1eb01d View commit details
    Browse the repository at this point in the history
  3. fix changelog

    likhita-809 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    1f3a896 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Merge branch 'release/v0.43.x' of ssh://github.com/cosmos/cosmos-sdk …

    …into mergify/bp/release/v0.43.x/pr-9720
    amaury1093 committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    26082d1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'release/v0.43.x' of https://github.com/cosmos/cosmos-sdk

    …into mergify/bp/release/v0.43.x/pr-9720
    likhita-809 committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    84b912c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a388ac View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2021

  1. Merge branch 'release/v0.43.x' of https://github.com/cosmos/cosmos-sdk

    …into mergify/bp/release/v0.43.x/pr-9720
    likhita-809 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    6877c45 View commit details
    Browse the repository at this point in the history
  2. try fixing lint issue

    likhita-809 committed Jul 28, 2021
    Configuration menu
    Copy the full SHA
    8daef5b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7d25789 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2021

  1. Merge branch 'release/v0.43.x' of https://github.com/cosmos/cosmos-sdk

    …into mergify/bp/release/v0.43.x/pr-9720
    likhita-809 committed Jul 29, 2021
    Configuration menu
    Copy the full SHA
    759af0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    87e434a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d17f9a6 View commit details
    Browse the repository at this point in the history